fix: Use arguments for to pass staged filenames to pre-commit task #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbode
changed the title
joshbode
force-pushed
the
pre-commit-args
branch
from
644b791 to
1d61aa4
Compare
jdx
reviewed
Dec 12, 2024
| set -- "$@" "${{ARG}}" | ||
| done < "${{PIPE}}" | ||
|
|
||
| exec mise run "{task}" "$@" |
There was a problem hiding this comment.
I already merged this but realized this should be exec mise run "{task}" -- "$@" though the only time that would matter is if you added a flag to the pre-commit task that had the exact string as a filename
There was a problem hiding this comment.
ah - good point, but yes... pretty unlikely - and hopefully people avoid filenames with leading dashes :)
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.