From 51068540014fdfc5a8fdcb3504c262f492f45009 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9rome=20Eertmans?= Date: Wed, 22 Jan 2025 21:26:49 +0100 Subject: [PATCH] fix(lib): pass skip argument to ManimCE --- CHANGELOG.md | 8 ++++++++ manim_slides/slide/manim.py | 5 ++++- uv.lock | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 20a12b33..f299d819 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 (unreleased)= ## [Unreleased](https://github.com/jeertmans/manim-slides/compare/v5.4.1...HEAD) +(unreleased-fixed)= +### Fixed + +- Fixed `start_skip_animations` to actually pass argument to ManimCE, + otherwise video animations were still rendered, just excluded from + the final output. + [#524](https://github.com/jeertmans/manim-slides/pull/524) + (v5.4.1)= ## [v5.4.1](https://github.com/jeertmans/manim-slides/compare/v5.4.0...v5.4.1) diff --git a/manim_slides/slide/manim.py b/manim_slides/slide/manim.py index 78d1ce0c..68842193 100644 --- a/manim_slides/slide/manim.py +++ b/manim_slides/slide/manim.py @@ -127,7 +127,10 @@ def next_slide( **kwargs: Any, ) -> None: Scene.next_section( - self, *args, skip_animations=base_slide_config.skip_animations, **kwargs + self, + *args, + skip_animations=base_slide_config.skip_animations | self._skip_animations, + **kwargs, ) BaseSlide.next_slide.__wrapped__( self, diff --git a/uv.lock b/uv.lock index 52ead1bd..aaa6df30 100644 --- a/uv.lock +++ b/uv.lock @@ -1526,7 +1526,7 @@ wheels = [ [[package]] name = "manim-slides" -version = "5.4.0" +version = "5.4.1" source = { editable = "." } dependencies = [ { name = "av" },