Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instagram placeholder shows 404 in preview #5

Closed
sillygwailo opened this issue Sep 16, 2013 · 2 comments
Closed

Instagram placeholder shows 404 in preview #5

sillygwailo opened this issue Sep 16, 2013 · 2 comments

Comments

@sillygwailo
Copy link

http://instagram.com/p/bWaCmcghHO/ is a valid Instagram URL, but if I were to do the following:

  1. visit http://embedresponsively.com/
  2. click on "Instagram"
  3. click on "Embed" without pasting anything in

It shows:

screenshot 2013-09-16 11 18 16

@jeffehobbs
Copy link
Owner

Yeah, but why wouldn't you paste something in? I guess I should add a better error handler there when the input is blank, but this has a "doctor it hurts when I do this" feel. :)

@sillygwailo
Copy link
Author

Because when you visit embedresponsively.com for the first time, it looks like there's a URL in the text box. Yes, it's greyed out, but it seemed to me like an example that you could actually try out. Wouldn't it be nice to see a preview of it in action if you don't have a specific URL in mind? So in addition to error handling (maybe the URL doesn't exist because they mistakenly typed in something after pasting), have clicking the button use the example URL that's greyed out to show what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants