Fix additon of extraneous fields #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicer tests. Also made some minor changes to where some logic is located. Still haven't tracked down the issue, we must be mocking something wrong.
lishaduck
commented
Nov 2, 2024
Comment on lines
174
to
+175
|
|
||
| workspaces ??= [] | ||
| const globPromises = workspaces.map((w) => | ||
| const globPromises = workspaces!.map((w) => |
There was a problem hiding this comment.
Yes, non-null assertations are bad, but I figured they fail fast, unlike ??=.
Same thing with the mocks.
Certainly negligible, but it looks cleaner this way too.
lishaduck
force-pushed
the
extraneous-fields
branch
from
56ecb96
to
25d203d
Compare
|
I gave up writing regression tests, but otherwise I'm happy with this. |
|
Also, if developing on node>=18, you can apply a patch and build with Patch
diff --git a/bin/typesync b/bin/typesync
index 95dbe55..e28f57c 100755
--- a/bin/typesync
+++ b/bin/typesync
@@ -1,4 +1,2 @@
#!/usr/bin/env node
-const { startCli } = require('../lib/cli')
-
-startCli()
+import('../dist/cli.mjs').then(({ startCli }) => startCli())Build command: |
|
I’m out on vacation, I’ll check on these when I get back. 👍 |
jeffijoe
reviewed
Nov 11, 2024
| ...subManifests.map(async (p) => | ||
| syncFile( | ||
| p, | ||
| await packageJSONService.readPackageFile(p), |
There was a problem hiding this comment.
Just curious, what did this change vs just reading the file from the file path in syncFile?
There was a problem hiding this comment.
I honestly don't remember 🤷♂️
|
Thanks, released as 0.13.4! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't tracked down the source of the bug yet.