avcodec/audiotoolboxenc: fix 7.1 channel mapping and sample rate #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnattu
force-pushed
the
fix-atenc-layout-samplerate
branch
2 times, most recently
from
7e7f6fb
to
5a806cb
Compare
Shadowghost
approved these changes
Oct 21, 2024
|
Upstreaming requires a bit more work to use a modernized api |
gnattu
force-pushed
the
fix-atenc-layout-samplerate
branch
from
5a806cb
to
f6a7308
Compare
Both AV_CHANNEL_LAYOUT_7POINT1_WIDE_BACK and AV_CHANNEL_LAYOUT_7POINT1 should be mapped to kAudioChannelLayoutTag_AAC_7_1_B, otherwise neither the back surround channel nor the side surround channel has sound. aac_at has stricter sample rate than other encoders which should be spcified to enable auto resampling. alac with sample rate higher than 38400 will not play on Apple devices, although higher sample rates are accepted by the encoder All encoders provided by AudioToolbox can handle 32bit integer samples, enable that for all encoders.
gnattu
force-pushed
the
fix-atenc-layout-samplerate
branch
from
f6a7308
to
142e51b
Compare
nyanmisaka
approved these changes
Oct 22, 2024
Bond-009
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Both
AV_CHANNEL_LAYOUT_7POINT1_WIDE_BACKandAV_CHANNEL_LAYOUT_7POINT1should be mapped to
kAudioChannelLayoutTag_AAC_7_1_B, otherwise neitherthe back surround channel nor the side surround channel has sound.
aac_at has stricter sample rate than other encoders which should be
spcified to enable auto resampling.
alac with sample rate higher than 38400 will not play on Apple devices,
although higher sample rates are accepted by the encoder
All encoders provided by AudioToolbox can handle 32bit integer samples,
enable that for all encoders.
This patch is probably upstream-able, will submit later.
Issues
This includes #484 to avoid conflicts. Marks as draft until that one is merged.