lavc/videotoolbox: remove opengl compatability key

[gnattu]

We are not using OpenGL and this compatability key could introduce performance penalty on some Macs. Performance difference is neglible on Apple Silicon but on old Intel Macs like the 2018 MacBook Air, decoding performance could be reduced by 15% as the IOSurface might make extra frame copies to reshape the pixel buffer.

Changes

Issues

[nyanmisaka]

kCVPixelBufferMetalCompatibilityKey Can this key bring any benefits in Metal?

[gnattu]

kCVPixelBufferMetalCompatibilityKey Can this key bring any benefits in Metal?

That key is not required as long as the pixel buffer is IOSurface backed and that key is always set:

jellyfin-ffmpeg/libavcodec/videotoolbox.c

Line 786 in 982e2b8

CFDictionarySetValue(buffer_attributes, kCVPixelBufferIOSurfacePropertiesKey, io_surface_properties);

For all IOSurface backed CVPixelBuffer the MTLTexture created by CVMetalTextureCacheCreateTextureFromImage will use the CVPixelBuffer itself for texture storage which means no GPU frame uploading or extra texture allocation is required, at least not on Apple GPUs.