Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand home rows to take up full width of the screen #1891

Merged
merged 8 commits into from
Nov 10, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Aug 1, 2024

This allows the rows to take advantage of the full width of the screen and also allows the user to peek at the previous item in the row on the left. The title text and current selection stay within the action safe zone

Changes

  • Expand home rows to take up full width of the screen
  • Use focusXOffset to move current selection back within the safe zone
  • Use rowLabelOffset to move the row title back within the safe zone
  • Update home row layout whenever the home screen is refreshed

@cewert cewert added the general-improvement Quality of life improvements that don't add new functionality. label Aug 1, 2024
@cewert cewert requested a review from a team as a code owner August 1, 2024 03:44
@cewert
Copy link
Member Author

cewert commented Aug 3, 2024

Reminder to add a user setting to allow user's to disable the new layout

@jellyfin-bot
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed in 15 days if there is no further activity.

@jellyfin-bot jellyfin-bot added the stale This issue/PR has gone stale. label Sep 5, 2024
@jellyfin-bot
Copy link
Contributor

This pull request has been closed because it has been inactive for 45 days. You may submit a new pull request if desired.

@cewert cewert removed the stale This issue/PR has gone stale. label Sep 25, 2024
@cewert cewert reopened this Sep 25, 2024
@cewert cewert marked this pull request as draft September 25, 2024 16:11
@cewert cewert marked this pull request as ready for review November 8, 2024 16:34
@cewert cewert requested a review from jimdogx November 8, 2024 16:36
locale/en_US/translations.ts Outdated Show resolved Hide resolved
@cewert cewert added new-setting A new user setting. and removed general-improvement Quality of life improvements that don't add new functionality. labels Nov 9, 2024
@cewert cewert merged commit 8a5714d into jellyfin:master Nov 10, 2024
7 checks passed
@cewert cewert deleted the expand-homerows branch November 17, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-setting A new user setting.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants