-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand home rows to take up full width of the screen #1891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cewert
added
the
general-improvement
Quality of life improvements that don't add new functionality.
label
Aug 1, 2024
Reminder to add a user setting to allow user's to disable the new layout |
This pull request has been inactive for 30 days and will be automatically closed in 15 days if there is no further activity. |
This pull request has been closed because it has been inactive for 45 days. You may submit a new pull request if desired. |
cewert
commented
Nov 8, 2024
… after updating setting
cewert
added
new-setting
A new user setting.
and removed
general-improvement
Quality of life improvements that don't add new functionality.
labels
Nov 9, 2024
jimdogx
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the rows to take advantage of the full width of the screen and also allows the user to peek at the previous item in the row on the left. The title text and current selection stay within the action safe zone
Changes
focusXOffset
to move current selection back within the safe zonerowLabelOffset
to move the row title back within the safe zone