Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config for validation.enabled not be applied correctly #151

Open
BMartinos opened this issue Jun 20, 2018 · 0 comments
Open

Config for validation.enabled not be applied correctly #151

BMartinos opened this issue Jun 20, 2018 · 0 comments

Comments

@BMartinos
Copy link
Contributor

Current behaviour:
The resource validation is being applied whether the config value is set to 'true' or 'false'

Expected behaviour
Setting the validation.enabled value to 'false' should disable the resource validation

Bug solution
https://github.com/jembi/hearth/blob/master/lib/server.js#L70

if (!config.getConf('validation:enabled')) {

The places where this config is being checked needs to be updated to check the string value coming back from the config. At the moment, the conditions are assuming these are Booleans and evaluate to true for both string values ('true' / 'false')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant