Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of openHIM mediator response is ambiguous #161

Open
armageddon opened this issue Oct 28, 2014 · 2 comments
Open

Status of openHIM mediator response is ambiguous #161

armageddon opened this issue Oct 28, 2014 · 2 comments

Comments

@armageddon
Copy link

The string status value of the mediator response is ambiguous. Does it mean :
Primary Route succeeded and secondary routes failed?
Some parts of the mediation succeeded and some failed?

How does this relate to the actual response code of the mediator request?
How do either of these relate to the response code of the request section in the response body?

Should there be rules about orchestration response codes and the response code in the request section of the body?

@rcrichton rcrichton modified the milestone: v1.1.x Nov 13, 2014
@rcrichton rcrichton modified the milestone: v1.1.x Feb 3, 2015
@rcrichton
Copy link
Member

The response status is now described here: https://github.com/jembi/openhim-core-js/wiki/RESTful-API-reference#transactions-resource However, it has been expressed that this is confusing and that we should think of ways to make this easiest to understand.

@rcrichton
Copy link
Member

Additional comments for @carlsbox:

Yes these are a little confusing. The word complete can be defined as "having all the necessary or appropriate parts." or meaning all done. in the definition here it seems that we are saying complete but not successful? this isn't making very much sense to an average user like me. We may need a legend and a good way to apss this is to ask it on the community on how best to phrase this and expand the legend. A good litmus paper test is to give it so someone like Chris in a blind manner (i.e. not seeing it before) and see what he thinks is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants