Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page to allow editing of a transaction before re-running #24

Open
rcrichton opened this issue May 26, 2014 · 3 comments
Open

Add a page to allow editing of a transaction before re-running #24

rcrichton opened this issue May 26, 2014 · 3 comments

Comments

@rcrichton
Copy link
Member

No description provided.

@BMartinos
Copy link
Collaborator

Are we still implementing this feature? if so, should only single rerun transactions be able to configure the rerun settings? It makes it a lot more complicated changing settings for multiple reruns as they could have different channels

@rcrichton
Copy link
Member Author

I think this feature needs a lot of thought as it could be difficult to implement correctly. We don't really have an implementation that wants to use this for now so I don't think we need to implement it for now. However, I agree this would probably only be for single re-runs.

@BMartinos
Copy link
Collaborator

I agree this should be for a single re-run as multiple rerun across diff channels makes it far more complex and I'm not sure what that use case could be.

The concept i had for the rerun custom settings it to load a popup modal with a form to capture the new rerun settings. The rerun settings can be saved to a new property in the transactions model ( rerun_settings ). When the transactions are being picked off the worker que we can query the rerun_settings property and apply accordingly.

Once the rerun has been done we can remove these "rerun_settings" to restore the original transactions to its original state or keep these settings in case the transaction needs to be rerun again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants