Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misleading ENV NAMES #623

Open
magp18 opened this issue Feb 16, 2024 · 0 comments
Open

misleading ENV NAMES #623

magp18 opened this issue Feb 16, 2024 · 0 comments

Comments

@magp18
Copy link

magp18 commented Feb 16, 2024

ENV variables have misleading names in that file

https://github.com/jembi/openhim-console/blob/b403f987be62781a2ecf3a9b0a1ac9845a353109/app/config/default-env.json#L6C18-L6C42

I proposed those changes

OPENHIM_CORE_MEDIATOR_HOSTNAME -> OPENHIM_CORE_HOSTNAME
OPENHIM_CONSOLE_HOSTPATH -> OPENHIM_CORE_API_HOSTPATH
OPENHIM_MEDIATOR_API_PORT -> OPENHIM_CORE_API_PORT

br
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magp18