I want to host a plugin in the Jenkins organization

[kishorikumar]

Repository URL

https://github.com/synopsys-sig/synopsys-security-scan-plugin

New Repository Name

synopsys-security-scan-plugin

Description

Synopsys Security Scan for Jenkins

Synopsys Security Scan Plugin for Jenkins enables you to configure your Jenkins pipeline to run Synopsys security testing and take action on the results. Synopsys Security Scan leverages Synopsys Bridge, allowing you to run tests for several Synopsys products from the command line.

• Install and configure Synopsys Security Scan plugin and Jenkins pipeline as described in the Readme section.

• Synopsys Security Scan will use the following Synopsys products leveraging Synopsys-Bridge.
  

Polaris

Black Duck

Coverity

GitHub users to have commit permission

@sig-tithi
@kishorikumar
@dmamidisynopsys

Jenkins project users to have release permission

sig_tithi
kishorikumar
dmamidisynopsys

Issue tracker

GitHub issues

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

• /audit-ok => the audit is complete, the hosting can continue 🎉.
• /audit-skip => the audit is not necessary, the hosting can continue 🎉.
• /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

• /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
• /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.26.3)

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: sig_tithi, kishorikumar (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: kishorikumar, dmamidisynopsys (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'GitHub Users to Authorize as Committers' are not valid GitHub usernames or are Organizations: sig_tithi
• ⚠️ Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan discovered 16 finding(s) 🔍.
For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

---

Remoting: Unsafe Callable

You can find detailed information about this finding here.

OsNameTask.java#22

Potentially unsafe Callable implementation OsNameTask#checkRoles

Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

SecurityScanStep.java#408

Potential CSRF vulnerability: If DescriptorImpl#doFillProductItems connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

Stapler: Missing permission check

You can find detailed information about this finding here.

SecurityScanStep.java#408

Potential missing permission check in DescriptorImpl#doFillProductItems

Jenkins: Plaintext password storage

You can find detailed information about this finding here.

ScannerGlobalConfig.java#67

Field should be reviewed whether it stores a password and is serialized to disk: polarisAccessToken

ScannerGlobalConfig.java#61

Field should be reviewed whether it stores a password and is serialized to disk: bitbucketToken

ScannerGlobalConfig.java#37

Field should be reviewed whether it stores a password and is serialized to disk: coverityConnectUserPassword

ScannerGlobalConfig.java#25

Field should be reviewed whether it stores a password and is serialized to disk: blackDuckApiToken

SecurityScanStep.java#87

Field should be reviewed whether it stores a password and is serialized to disk: bitbucket_token

SecurityScanStep.java#73

Field should be reviewed whether it stores a password and is serialized to disk: polaris_access_token

SecurityScanStep.java#57

Field should be reviewed whether it stores a password and is serialized to disk: coverity_passphrase

SecurityScanStep.java#43

Field should be reviewed whether it stores a password and is serialized to disk: blackduck_token

Api.java#17

Field should be reviewed whether it stores a password and is serialized to disk: token

Project.java#16

Field should be reviewed whether it stores a password and is serialized to disk: key

BlackDuck.java#16

Field should be reviewed whether it stores a password and is serialized to disk: token

User.java#16

Field should be reviewed whether it stores a password and is serialized to disk: password

Polaris.java#14

Field should be reviewed whether it stores a password and is serialized to disk: accessToken

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: sig_tithi (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: kishorikumar, dmamidisynopsys (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⚠️ Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[kishorikumar]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: dmamidisynopsys (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⚠️ Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[kishorikumar]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⚠️ Warning: No pom.xml detected.

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[NotMyFault]

Please recreate your repository using the Jenkins archetype for the maven plugin as base layout: https://www.jenkins.io/doc/developer/tutorial/create/
Choosing "4" and modifying the example java classes.

[jahid1209]

@NotMyFault
Are you requesting to restructure our repository with Maven as the build tool instead of Gradle?
If so, is this a new requirement to publish a plugin in the marketplace? As we have three plugins in the marketplace developed with Gradle.
Please checkout the repositories for the aforementioned three plugins.

• synopsys-polaris-plugin

• synopsys-coverity-plugin

• synopsys-detect-plugin

[MarkEWaite]

Yes, @jahid1209, @NotMyFault is requesting that you use Apache Maven for your plugin rather than Gradle. The build tooling improvements that have been made over the last 12-18 months have been implemented in Apache Maven. Jenkins core, Jenkins libraries, and the vast majority of Jenkins plugins use Apache Maven. You'll have a better Jenkins development experience if you use Apache Maven.

As an unrelated note, will Synopsys be removing the Prototype.js JavaScript library use from the Synopsys Coverity plugin as noted in JENKINS-71308? The May 2023 blog post announced that the Prototype.js library will be removed from Jenkins. Weekly releases beginning with 2.426 (Oct 3, 2023) no longer include that JavaScript library. LTS releases beginning Nov 15, 2023 will no longer include that library.

Instructions on the steps to remove that library are in the blog post.

[jahid1209]

@MarkEWaite
Thanks for your detailed response. We will migrate our project accordingly.

Also, thanks for the heads up about Synopsys Coverity plugin. We will get back to you after necessary changes are done.

[dmamidibd]

Hello @MarkEWaite Is this recommendation or absolute requirement? I am only asking since it is saying "Warning". Our current build/release pipelines are based out of gradle just like other plugins. Those all need to be changed. Can we make that change at a later point? Please advise. Thank you for your prompt responses!

[MarkEWaite]

I believe that @NotMyFault is trying to guide you to future success on this new plugin. Switching this plugin from gradle to maven gives you a low risk location to explore the changes you'll need to make in your internal build and release processes. This plugin has no users currently, since it is not yet released. That's the safest place to learn more about the transition.

I'll leave it to @NotMyFault to answer if it is mandatory or a recommendation. There have been discussions in the developer mailing list, but I don't recall the details of the discussions.

[NotMyFault]

We're not accepting new plugin hosting requests using any other build tool but maven anymore. The declining interest of contributors to implement, document and maintain feature parity of the Gradle JPI plugin with the maven ecosystem led to this decision put in place.

[dmamidibd]

Ok. Thanks for responses. This seems a bit restrictive to me. Gradle is widely used and might be daunting change for existing build systems depending on the usage. But if it is absolute requirement now, we will evaluate the changes needed on our end and get back.

[MarkEWaite]

This seems a bit restrictive to me. Gradle is widely used and might be daunting change for existing build systems depending on the usage

If someone wants to provide and support the Maven based Jenkins tooling updates for Gradle projects, they are welcome to do so. We've not had anyone offer to do that. Are you interested in doing that?

[daniel-beck]

Noting previous context: https://groups.google.com/g/jenkinsci-dev/c/lHQAiEepBiw/m/TiXBGbkpAwAJ

[zaman-akib]

/request-security-scan

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jahid1209]

/hosting re-check

[dmamidibd]

Hello Jenkins hosting team! cc: @MarkEWaite and @NotMyFault

Now that all checks are complete and I believe we are good from the above comment, can you provide us an ETA if possible when hosting will be complete on to jenkinsci org? Thank you for all your help!

[NotMyFault]

/request-security-scan

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[NotMyFault]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[NotMyFault]

Hey @kishorikumar,

I took a brief look over your hosting request and have some feedback for you:

• You picked the correct groupId in your pom (io.jenkins.plugins), but referenced the wrong class path.
  https://github.com/synopsys-sig/synopsys-security-scan-plugin/tree/main/src/main/java/com/synopsys/integration/jenkins/scan should be located at io.jenkins.plugins.synopsys.security.scan, matching the groupId and artifactId.
• https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L31 Is obsolete and should be removed. The java version is defined at the parent pom level nowadays, and no longer on the project pom.
• https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L35 Instead of suppressing, I'd recommend addressing them.
• https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L74 is obsolete and should be removed. The version is defined in the bom.
• https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L79 is obsolete and should be removed. The version is defined in the bom.
  Additionally, I recommend removing entries from your pom your plugin doesn't depend on.
• https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/src/test/java/com/synopsys/integration/jenkins/scan/global/UtilityTest.java#L168-L169 It's unlikely that reflecting access that way done works in Java 17 or newer.

[kishorikumar]

Hey @kishorikumar,

I took a brief look over your hosting request and have some feedback for you:

• You picked the correct groupId in your pom (io.jenkins.plugins), but referenced the wrong class path.
  https://github.com/synopsys-sig/synopsys-security-scan-plugin/tree/main/src/main/java/com/synopsys/integration/jenkins/scan should be located at io.jenkins.plugins.synopsys.security.scan, matching the groupId and artifactId.
• https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L31 Is obsolete and should be removed. The java version is defined at the parent pom level nowadays, and no longer on the project pom.
• https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L35 Instead of suppressing, I'd recommend addressing them.
• https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L74 is obsolete and should be removed. The version is defined in the bom.
• https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/pom.xml#L79 is obsolete and should be removed. The version is defined in the bom.
  Additionally, I recommend removing entries from your pom your plugin doesn't depend on.
• https://github.com/synopsys-sig/synopsys-security-scan-plugin/blob/80f0aa918a26eb83e9918852c0781fc0a4a76f30/src/test/java/com/synopsys/integration/jenkins/scan/global/UtilityTest.java#L168-L169 It's unlikely that reflecting access that way done works in Java 17 or newer.

Hi @NotMyFault Than you for your feedbacks. We have addressed all the feedbacks. Please have a look on it, re-review and provide us further feedbacks if you get any. Thank you for all your help!

[jahid1209]

/request-security-scan

[jahid1209]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[dmamidibd]

@NotMyFault All the items in your last comment are addressed now. Can you please let us know the ETA for hosting on "jenkinsci" org to be complete? Thank you for all your help.

[NotMyFault]

/hosting host

[jenkins-infra-bot]

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/synopsys-security-scan-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

• Accept the invitation to the Jenkins CI Org on Github
• Add additional users for upload permissions, if needed
• Releasing your plugin

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content:
https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile

Welcome aboard!