Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin-multibranch-build-strategy-extension.yml #3571

Merged

Conversation

igalg
Copy link
Contributor

@igalg igalg commented Oct 16, 2023

enable cd

Link to GitHub repository

When modifying release permission

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

Preview Give feedback

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

CD checklist (for submitters)

Preview Give feedback

Reviewer checklist

Preview Give feedback

There are IRC Bot commands for it.

@igalg igalg requested a review from a team as a code owner October 16, 2023 17:08
@igalg
Copy link
Contributor Author

igalg commented Oct 16, 2023

@igalg
Copy link
Contributor Author

igalg commented Oct 19, 2023

@NotMyFault   Hi i just wanted to be sure that the pr is waiting for review or for something else
Thank's a lot Igal

@NotMyFault
Copy link
Member

NotMyFault commented Oct 19, 2023

NotMyFault   Hi i just wanted to be sure that the pr is waiting for review or for something else Thank's a lot Igal

I don't have the capacity to review a PR with a diff sizing +1.6k/-0.7k filled with unrelated content to CD. Please link a PR enabling CD only.

@FrogDevelopper
Copy link
Contributor

new PR was created with only changes for automatic release
jenkinsci/multibranch-build-strategy-extension-plugin#19

@NotMyFault
Copy link
Member

new PR was created with only changes for automatic release jenkinsci/multibranch-build-strategy-extension-plugin#19

The PR linked is incomplete. The pom hasn't been incrementalified yet. Take a look at the documentation on how to do that.

@FrogDevelopper
Copy link
Contributor

@NotMyFault
Pom updated

@NotMyFault NotMyFault merged commit 688967f into jenkins-infra:master Nov 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants