Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting request for ct-coverage plugin #3584

Closed
hyodol53 opened this issue Oct 24, 2023 · 22 comments
Closed

Hosting request for ct-coverage plugin #3584

hyodol53 opened this issue Oct 24, 2023 · 22 comments
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success

Comments

@hyodol53
Copy link

hyodol53 commented Oct 24, 2023

Repository URL

https://github.com/SuresoftTechnologies/ct-coverage

New Repository Name

ct-coverage-plugin

Description

This is a plugin forked from Jacoco. Reads an xml file and displays coverage information.
The xml file format is created by CT, and this file format is a modified version of the jacoco xml file.

GitHub users to have commit permission

@hyodol53

Jenkins project users to have release permission

hyojae

Issue tracker

Jira

@hyodol53 hyodol53 added the hosting-request Request to host a component in jenkinsci label Oct 24, 2023
@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.26.14)

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Oct 24, 2023
@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: You must specify an <scm> block in your pom.xml. See https://maven.apache.org/pom.html#SCM for more information.
  • ⛔ Required: The parent pom version '4.70' should be at least '4.71' or higher.
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: hyojae (reports are re-synced hourly, wait to re-check for a bit after logging in)
  • ⛔ Required: 'New Repository Name' must end with "-plugin" (disregard if you are not requesting hosting of a plugin)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan discovered 9 finding(s) 🔍.
For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.


Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

CoverageObject.java#298
Potential CSRF vulnerability: If CoverageObject#doGraph connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
CTProjectAction.java#53
Potential CSRF vulnerability: If CTProjectAction#doGraph connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
CoverageReport.java#227
Potential CSRF vulnerability: If CoverageReport#doJacocoExec connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

Stapler: Missing permission check

You can find detailed information about this finding here.

CoverageObject.java#298
Potential missing permission check in CoverageObject#doGraph
CTProjectAction.java#53
Potential missing permission check in CTProjectAction#doGraph
CoverageReport.java#227
Potential missing permission check in CoverageReport#doJacocoExec

Jenkins: Potentially unsafe classes

You can find detailed information about this finding here.

CoverageReport.java#91
This use of class [org.apache.commons.digester3.Digester](1) should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.
CoverageReport.java#77
This use of class [org.apache.commons.digester3.Digester](1) should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.
CoverageReport.java#252
This use of class [org.apache.commons.digester3.Digester](1) should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.

@jenkins-cert-app jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Oct 24, 2023
@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

  • ⛔ Required: You must specify an <scm> block in your pom.xml. See https://maven.apache.org/pom.html#SCM for more information.
  • ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: hyojae (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

@hyodol53
Copy link
Author

/audit-review

@jenkins-cert-app jenkins-cert-app added security-audit-correction-review The hosting request code was adjusted, a new security review must be done and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Oct 24, 2023
@hyodol53
Copy link
Author

/hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@github-actions github-actions bot added bot-check-complete Automated hosting checks passed and removed needs-fix labels Oct 24, 2023
@hyodol53
Copy link
Author

/hosting host

@Wadeck
Copy link
Collaborator

Wadeck commented Oct 24, 2023

@hyodol53

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.

I do not see any new commits in your repository, meaning that if you want to pass the check, you have to provide justifications for every finding :) You have explanations about how to correct/mark as false positive the different findings from the security scan.

@jenkins-cert-app jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-correction-review The hosting request code was adjusted, a new security review must be done labels Oct 24, 2023
@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan discovered 9 finding(s) 🔍.
For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.


Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

CoverageObject.java#298
Potential CSRF vulnerability: If CoverageObject#doGraph connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
CTProjectAction.java#53
Potential CSRF vulnerability: If CTProjectAction#doGraph connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
CoverageReport.java#227
Potential CSRF vulnerability: If CoverageReport#doJacocoExec connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

Stapler: Missing permission check

You can find detailed information about this finding here.

CoverageObject.java#298
Potential missing permission check in CoverageObject#doGraph
CTProjectAction.java#53
Potential missing permission check in CTProjectAction#doGraph
CoverageReport.java#227
Potential missing permission check in CoverageReport#doJacocoExec

Jenkins: Potentially unsafe classes

You can find detailed information about this finding here.

CoverageReport.java#91
This use of class [org.apache.commons.digester3.Digester](1) should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.
CoverageReport.java#77
This use of class [org.apache.commons.digester3.Digester](1) should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.
CoverageReport.java#252
This use of class [org.apache.commons.digester3.Digester](1) should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.

@jenkins-cert-app jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Oct 24, 2023
@hyodol53
Copy link
Author

/request-security-scan

@jenkins-cert-app jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Oct 24, 2023
@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan discovered 9 finding(s) 🔍.
For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.


Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

CoverageObject.java#298
Potential CSRF vulnerability: If CoverageObject#doGraph connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
CTProjectAction.java#53
Potential CSRF vulnerability: If CTProjectAction#doGraph connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST
CoverageReport.java#227
Potential CSRF vulnerability: If CoverageReport#doJacocoExec connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

Stapler: Missing permission check

You can find detailed information about this finding here.

CoverageObject.java#298
Potential missing permission check in CoverageObject#doGraph
CTProjectAction.java#53
Potential missing permission check in CTProjectAction#doGraph
CoverageReport.java#227
Potential missing permission check in CoverageReport#doJacocoExec

Jenkins: Potentially unsafe classes

You can find detailed information about this finding here.

CoverageReport.java#91
This use of class [org.apache.commons.digester3.Digester](1) should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.
CoverageReport.java#77
This use of class [org.apache.commons.digester3.Digester](1) should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.
CoverageReport.java#252
This use of class [org.apache.commons.digester3.Digester](1) should be reviewed for unsafe behavior, like allowing XML External Entity injection, or arbitrary code execution.

@jenkins-cert-app jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Oct 24, 2023
@hyodol53
Copy link
Author

/request-security-scan

@jenkins-cert-app jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Oct 26, 2023
@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan discovered 2 finding(s) 🔍.
For each of them, either apply the recommended correction, suppress the warning or provide a justification.

Once you're done, either re-run the scan with /request-security-scan or request the Security team to review your justifications with /audit-review.


Stapler: Missing POST/RequirePOST annotation

You can find detailed information about this finding here.

CoverageObject.java#298
Potential CSRF vulnerability: If CoverageObject#doGraph connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

Stapler: Missing permission check

You can find detailed information about this finding here.

CoverageObject.java#298
Potential missing permission check in CoverageObject#doGraph

@jenkins-cert-app jenkins-cert-app added security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request and removed security-audit-todo The security team needs to audit the hosting request code labels Oct 26, 2023
@hyodol53
Copy link
Author

/request-security-scan

@jenkins-cert-app jenkins-cert-app added security-audit-todo The security team needs to audit the hosting request code and removed security-audit-needs-correction The security audit revealed issues that must be corrected from the hosting request labels Oct 26, 2023
@jenkins-cert-app
Copy link
Collaborator

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉


💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

@jenkins-cert-app jenkins-cert-app added security-audit-done The hosting request code passed the security audit with success and removed security-audit-todo The security team needs to audit the hosting request code labels Oct 26, 2023
@hyodol53
Copy link
Author

/hosting host

@NotMyFault
Copy link
Member

NotMyFault commented Oct 26, 2023

/hosting host

You're not permitted to run that command.

/hosting re-check

@github-actions
Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@hyodol53
Copy link
Author

/hosting re-check

Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@timja
Copy link
Member

timja commented Nov 15, 2023

New coverage models should be added to the coverage plugin not a whole new plugin:
https://github.com/jenkinsci/coverage-plugin

If your coverage tool is not yet supported by the code coverage plugin you can provide a pull request for the Coverage Model.

Could you take a look at that please?


Apologies for the delay in review

@NotMyFault NotMyFault closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success
Projects
None yet
Development

No branches or pull requests

5 participants