Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyway API plugin #3631

Closed
jonesbusy opened this issue Nov 24, 2023 · 9 comments
Closed

Flyway API plugin #3631

jonesbusy opened this issue Nov 24, 2023 · 9 comments
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success

Comments

@jonesbusy
Copy link
Contributor

Repository URL

https://github.com/jonesbusy/flyway-api-plugin

New Repository Name

flyway-api-plugin

Description

I would like to provide a new API plugin to provide flyway dependencies to perform database migration (for either plugin internals or implement build steps)

Possible consumers

GitHub users to have commit permission

@jonesbusy

Jenkins project users to have release permission

jonesbusy

Issue tracker

GitHub issues

@jonesbusy jonesbusy added the hosting-request Request to host a component in jenkinsci label Nov 24, 2023
@jenkins-cert-app
Copy link
Collaborator

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

  • /audit-ok => the audit is complete, the hosting can continue 🎉.
  • /audit-skip => the audit is not necessary, the hosting can continue 🎉.
  • /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

  • /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
  • /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.26.21)

@jenkins-cert-app jenkins-cert-app added the security-audit-todo The security team needs to audit the hosting request code label Nov 24, 2023
Copy link

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

@github-actions github-actions bot added the bot-check-complete Automated hosting checks passed label Nov 24, 2023
@jenkins-cert-app
Copy link
Collaborator

❌ Jenkins Security Scan failed.
The Security team was notified about this.

@Wadeck
Copy link
Collaborator

Wadeck commented Nov 24, 2023

Error:

[2023-11-24 07:15:33] [autobuild] [ERROR] Failed to execute goal org.jenkins-ci.tools:maven-hpi-plugin:3.50:hpi (default-hpi) on project flyway-api: Error assembling hpi: invalid header field -> [Help 1]
[2023-11-24 07:15:33] [autobuild] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.jenkins-ci.tools:maven-hpi-plugin:3.50:hpi (default-hpi) on project flyway-api: Error assembling hpi: invalid header field

I checked locally and it seems to build correctly. So perhaps something related to the autobuild tooling we have :)

After a quick look, it's fine from security PoV.

@Wadeck
Copy link
Collaborator

Wadeck commented Nov 24, 2023

/audit-ok

@jenkins-cert-app jenkins-cert-app added security-audit-done The hosting request code passed the security audit with success and removed security-audit-todo The security team needs to audit the hosting request code labels Nov 24, 2023
@timja
Copy link
Member

timja commented Nov 24, 2023

  1. you have a typo in your index.jelly file saying it's jax-rs:

This plugin provides the JAX-RS 2.1 APIs for other plugins.

  1. Jenkinsfile should have Java 21 in it

  2. Name should be updated: https://github.com/jonesbusy/flyway-api-plugin/blob/main/pom.xml#L14


Rest looks fine

@jonesbusy
Copy link
Contributor Author

@timja Thanks it's fixed now

@timja
Copy link
Member

timja commented Nov 24, 2023

/hosting host

@jenkins-infra-bot
Copy link
Contributor

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/flyway-api-plugin

GitHub issues has been selected for issue tracking and was enabled for the forked repo.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content:
https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile

Welcome aboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-check-complete Automated hosting checks passed hosting-request Request to host a component in jenkinsci security-audit-done The hosting request code passed the security audit with success
Projects
None yet
Development

No branches or pull requests

5 participants