Request for hosting azure-kubernetes-credentials-plugin

[TueDissingWork]

Repository URL

https://github.com/TueDissingWork/azure-kubernetes-credentials-plugin

New Repository Name

azure-kubernetes-credentials-plugin

Description

This plugin provides an extension for the kubernetes-credentials-provider-plugin plugin, and the azure-credentials-plugin that extend the Kubernetes credentials provider to create the special credential type required by the azure-credentials when interacting with Azure Cloud.

GitHub users to have commit permission

TueDissingWork

Jenkins project users to have release permission

toodissing

Issue tracker

Jira

[jenkins-cert-app]

Security audit, information and commands

The security team is auditing all the hosting requests, to ensure a better security by default.

This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.

Commands

The bot will parse all comments, and it will check if any line start with a command.

Security team only:

• /audit-ok => the audit is complete, the hosting can continue 🎉.
• /audit-skip => the audit is not necessary, the hosting can continue 🎉.
• /audit-findings => the audit reveals some issues that require corrections ✏️.

Anyone:

• /request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository 🔍.
• /audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings 👀. It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.26.28)

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: toodissing (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: toodissing (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[TueDissingWork]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It appears you have some issues with your hosting request. Please see the list below and correct all issues marked Required. Your hosting request will not be approved until these issues are corrected. Issues marked with Warning or Info are just recommendations and will not stall the hosting process.

• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Jira: toodissing (reports are re-synced hourly, wait to re-check for a bit after logging in)
• ⛔ Required: The following usernames in 'Jenkins project users to have release permission' need to log into Artifactory: toodissing (reports are re-synced hourly, wait to re-check for a bit after logging in)

You can re-trigger a check by editing your hosting request or by commenting /hosting re-check

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jonesbusy]

There is many reference on "gitlab" that you copied into your plugin

As explained https://groups.google.com/g/jenkinsci-dev/c/bvKkdTS9NEY is better to start from empty archetype and add your class there

• https://github.com/TueDissingWork/azure-kubernetes-credentials-plugin?tab=readme-ov-file#gitlab-kubernetes-credentials-plugin
• https://github.com/TueDissingWork/azure-kubernetes-credentials-plugin/blob/main/.github/CODEOWNERS
• Also it container worklows that you probably don't need (updatecli)
• CD workflow must also be added afterward if you decide to use continuous delivery on your plugin

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[jenkins-cert-app]

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! 🎉

---

💡 The Security team recommends that you are setting up the scan in your repository by following our guide.

[daniel-beck]

Sorry about the noise. I informed Wadeck about this to look into what's stuck in the backend.

[Wadeck]

Normally the event is killed, so no other message will be sent :) Fortunately the scan is not instantaneous, otherwise it would have been more spammy :D

⚠️ Please do not request another scan on this particular repository, I will need to adjust some settings, otherwise it will spam again. It's on my side, nothing wrong with your repo, especially as you pass the scan ;)

[TueDissingWork]

Normally the event is killed, so no other message will be sent :) Fortunately the scan is not instantaneous, otherwise it would have been more spammy :D

⚠️ Please do not request another scan on this particular repository, I will need to adjust some settings, otherwise it will spam again. It's on my side, nothing wrong with your repo, especially as you pass the scan ;)

No problem - Let me know when it is safe to start the re-scan.

[TueDissingWork]

There is many reference on "gitlab" that you copied into your plugin

As explained https://groups.google.com/g/jenkinsci-dev/c/bvKkdTS9NEY is better to start from empty archetype and add your class there

* https://github.com/TueDissingWork/azure-kubernetes-credentials-plugin?tab=readme-ov-file#gitlab-kubernetes-credentials-plugin

* https://github.com/TueDissingWork/azure-kubernetes-credentials-plugin/blob/main/.github/CODEOWNERS

* Also it container worklows that you probably don't need (updatecli)

* CD workflow must also be added afterward if you decide to use continuous delivery on your plugin

Did some cleanup now, based on the Jenkins empty plugin archetype - should be more clean now.

[jonesbusy]

There is many reference on "gitlab" that you copied into your plugin
As explained https://groups.google.com/g/jenkinsci-dev/c/bvKkdTS9NEY is better to start from empty archetype and add your class there

* https://github.com/TueDissingWork/azure-kubernetes-credentials-plugin?tab=readme-ov-file#gitlab-kubernetes-credentials-plugin

* https://github.com/TueDissingWork/azure-kubernetes-credentials-plugin/blob/main/.github/CODEOWNERS

* Also it container worklows that you probably don't need (updatecli)

* CD workflow must also be added afterward if you decide to use continuous delivery on your plugin

Did some cleanup now, based on the Jenkins empty plugin archetype - should be more clean now.

Looks good for me. I will let infra guys validate it as well

[Wadeck]

Let me know when it is safe to start the re-scan.

I don't think I will be done on this before this request is "done" :)

[alecharp]

Hello,

I see that the source code of the plugin is inside the folder src/main/java/io/jenkins/plugins/plugins/azurecredentialsk8s but the classes are declaring the package io.jenkins.plugins.azurecredentialsk8s. Same for the tests classes. Could you fix that (removing one level of plugins folder)?

The artifactId in the pom.xml file must not have the suffix -plugin. Can you also fix the name tag in the same file.

There is also the duplication of the suffix -plugin in the .github/CODEOWNER file to remove.

Thanks.

[TueDissingWork]

Hello,

I see that the source code of the plugin is inside the folder src/main/java/io/jenkins/plugins/plugins/azurecredentialsk8s but the classes are declaring the package io.jenkins.plugins.azurecredentialsk8s. Same for the tests classes. Could you fix that (removing one level of plugins folder)?

The artifactId in the pom.xml file must not have the suffix -plugin. Can you also fix the name tag in the same file.

There is also the duplication of the suffix -plugin in the .github/CODEOWNER file to remove.

Thanks.

Nicely spotted. A small copy-and-paste error. Oops.
Should have been corrected now.

[NotMyFault]

Looks good so far, but you want to run mvn spotless:apply to satisfy spotless.

[TueDissingWork]

Looks good so far, but you want to run mvn spotless:apply to satisfy spotless.
Good to hear.

The spotless rules should now be applied. See TueDissingWork/azure-kubernetes-credentials-plugin#9 for further deails.

[NotMyFault]

/hosting re-check

[github-actions]

Hello from your friendly Jenkins Hosting Checker

It looks like you have everything in order for your hosting request. A member of the Jenkins hosting team will check over things that I am not able to check(code review, README content, etc) and process the request as quickly as possible. Thank you for your patience.

Hosting team members can host this request with /hosting host

[NotMyFault]

/hosting host

[jenkins-infra-bot]

Hosting request complete, the code has been forked into the jenkinsci project on GitHub as https://github.com/jenkinsci/azure-kubernetes-credentials-plugin

A Jira component named azure-kubernetes-credentials-plugin has also been created with toodissing as the default assignee for issues.

A pull request has been created against the repository permissions updater to setup release permissions. Additional users can be added by modifying the created file.

Please delete your original repository (if there are no other forks), under 'Danger Zone', so that the jenkinsci organization repository is the definitive source for the code. If there are other forks, please contact GitHub support to make the jenkinsci repo the root of the fork network (mention that Jenkins approval was given in support request 569994). Also, please make sure you properly follow the documentation on documenting your plugin so that your plugin is correctly documented.

You will also need to do the following in order to push changes and release your plugin:

• Accept the invitation to the Jenkins CI Org on Github
• Add additional users for upload permissions, if needed
• Releasing your plugin

In order for your plugin to be built by the Jenkins CI Infrastructure and check pull requests, please add a Jenkinsfile to the root of your repository with the following content:
https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile

Welcome aboard!