-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artifactory Groovy Script conversion #3938
Artifactory Groovy Script conversion #3938
Conversation
Waiting for #3936 get merged |
…-api-conversation
…-api-conversation
…d handle spotbugs
…ry-api-conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok from what I can see, one nit, have you tested this in some way?
src/main/java/io/jenkins/infra/repository_permissions_updater/ArtifactoryImpl.java
Outdated
Show resolved
Hide resolved
I would compare the json files of the master and my branch, there should be no differences. I would consider it valid |
@daniel-beck do you want to check this one? |
@timja Thanks for the ping. I remember test coverage wasn't great when I built this (anything?) so how well has this been tested? Any schedule for merge? |
No test coverage that I can tell. Schedule for merge no not really although this is done as part of GSOC I believe so @NotMyFault or @TheMeinerLP may be able to comment. |
Test coverage does not exist (yet), but in case somethings breaks, we can always revert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine from my pov
This PR converts the two last Groovy scripts and reworks the code in readability. The framework Reactor was integrated to allow more speed and parallel work.
Many of the main parts have been split from the Updater class into smaller classes, moving the Updater class into a launcher package to separate start classes from other logic.
Java 21 features such as sealed interfaces are now also used in the core to build a better API.