New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-66740] Fix credentials permissions checks #4

Open

Dohbedoh wants to merge 1 commit into jenkinsci:master from Dohbedoh:JENKINS-66740

Dohbedoh commented Jul 14, 2022 •

edited

Loading

Fixes JENKINS-66740 / Blazemeter#89.

Use @AncestorInPath and AccessControlled to do a smart check based on the context
Remove the jelly part that was preventing from creating also other types of credentials.

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue


          [JENKINS-66740] Fix credentials permissions checks

ed43ca6

Author

Dohbedoh commented Jul 14, 2022

ping @dnyanesh-nagre-blazerunner
Not sure if a PR needs to be created downstream ? In case I have also opened Blazemeter#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet