Apply suggestions from code review

Co-authored-by: Ullrich Hafner <[email protected]>
jenkinsci · Apr 4, 2024 · 469908a · 469908a
1 parent 74e1aa1
commit 469908a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/test/java/io/jenkins/plugins/checks/steps/WithChecksStepITest.java b/src/test/java/io/jenkins/plugins/checks/steps/WithChecksStepITest.java
@@ -89,10 +89,10 @@ public void publishChecksShouldIncludeEnclosingBlocksWhenEnabled() {
 
         buildSuccessfully(job);
 
-        assertThat(getFactory().getPublishedChecks().size()).isEqualTo(1);
+        assertThat(getFactory().getPublishedChecks()).hasSize(1);
         ChecksDetails autoChecks = getFactory().getPublishedChecks().get(0);
 
-        assertThat(autoChecks.getName()).isPresent().get().isEqualTo("tests / Integration Test");
+        assertThat(autoChecks.getName()).contains("tests / Integration Test");
         assertThat(autoChecks.getStatus()).isEqualTo(ChecksStatus.IN_PROGRESS);
         assertThat(autoChecks.getConclusion()).isEqualTo(ChecksConclusion.NONE);
     }

diff --git a/src/test/resources/design.puml b/src/test/resources/design.puml
@@ -13,7 +13,7 @@ skinparam component {
 [Checks] <<..checks>>
 
 [Steps] --> [API]
-[Steps] --> [Utils
+[Steps] --> [Utils]
 [Status] --> [API]
 [Status] --> [Utils]
 [Checks] --> [API]