From 469908aeb8dd55d5378c35c09b13787e0e543007 Mon Sep 17 00:00:00 2001 From: Tim Jacomb <21194782+timja@users.noreply.github.com> Date: Thu, 4 Apr 2024 20:48:18 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Ullrich Hafner --- .../io/jenkins/plugins/checks/steps/WithChecksStepITest.java | 4 ++-- src/test/resources/design.puml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/java/io/jenkins/plugins/checks/steps/WithChecksStepITest.java b/src/test/java/io/jenkins/plugins/checks/steps/WithChecksStepITest.java index f8613f8c..dd3fad92 100644 --- a/src/test/java/io/jenkins/plugins/checks/steps/WithChecksStepITest.java +++ b/src/test/java/io/jenkins/plugins/checks/steps/WithChecksStepITest.java @@ -89,10 +89,10 @@ public void publishChecksShouldIncludeEnclosingBlocksWhenEnabled() { buildSuccessfully(job); - assertThat(getFactory().getPublishedChecks().size()).isEqualTo(1); + assertThat(getFactory().getPublishedChecks()).hasSize(1); ChecksDetails autoChecks = getFactory().getPublishedChecks().get(0); - assertThat(autoChecks.getName()).isPresent().get().isEqualTo("tests / Integration Test"); + assertThat(autoChecks.getName()).contains("tests / Integration Test"); assertThat(autoChecks.getStatus()).isEqualTo(ChecksStatus.IN_PROGRESS); assertThat(autoChecks.getConclusion()).isEqualTo(ChecksConclusion.NONE); } diff --git a/src/test/resources/design.puml b/src/test/resources/design.puml index 9c0e93dc..8bef7833 100644 --- a/src/test/resources/design.puml +++ b/src/test/resources/design.puml @@ -13,7 +13,7 @@ skinparam component { [Checks] <<..checks>> [Steps] --> [API] -[Steps] --> [Utils +[Steps] --> [Utils] [Status] --> [API] [Status] --> [Utils] [Checks] --> [API]