From 7f098a55ae9fa0b42472c77aa4573858836a5a50 Mon Sep 17 00:00:00 2001 From: Mark Waite Date: Thu, 7 Dec 2023 11:22:57 -0700 Subject: [PATCH] [JENKINS-72364] Close provider dialog window when cancel is clicked One change from https://github.com/jenkinsci/credentials-plugin/pull/491 was applied to a reference that was not using Prototype.js. https://issues.jenkins.io/browse/JENKINS-72364 is the issue report. Confirmed interactively that I can see the problem before the change and that with this change the problem is resolved. --- src/main/resources/lib/credentials/dialog.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/lib/credentials/dialog.js b/src/main/resources/lib/credentials/dialog.js index 87b2419e9..56a18a39f 100644 --- a/src/main/resources/lib/credentials/dialog.js +++ b/src/main/resources/lib/credentials/dialog.js @@ -3,5 +3,5 @@ Behaviour.specify("#credentials-add-submit", 'credentials-dialog-add', 0, functi }); Behaviour.specify("#credentials-add-abort", 'credentials-dialog-abort', 0, function (e) { - e.onclick = (_) => window.credentials.dialog.style.display = "none"; + e.onclick = (_) => window.credentials.dialog.hide(); }); \ No newline at end of file