Add support for Windows dial-in commands #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Roemer Would it be possible for you to have a look into it whenever you can please? |
jglick
reviewed
Sep 14, 2023
| @@ -57,7 +58,7 @@ public DockerSwarmAgentTemplate() { | |||
|
|
|||
| @DataBoundConstructor | |||
| public DockerSwarmAgentTemplate(final String image, final String hostBinds, final String hostNamedPipes, final String dnsIps, | |||
| final String dnsSearchDomains, final String command, final String user, final String workingDir, | |||
| final String dnsSearchDomains, final String unixCommand,final String windowsCommand, final String user, final String workingDir, | |||
There was a problem hiding this comment.
Note that this was an incompatible change. For example, a JCasC bundle that worked with 1.11 will not work with 1.12, and vice-versa. Recommend renaming unixCommand back to command before releasing this.
There was a problem hiding this comment.
Many thanks for the hint! I created a PR to rename the needed parts: #127
Did I rename enough or do I need to rename more unixCommands to command?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the user to add a custom Windows command to use for container dial-in, as opposed to the current hard-coded behaviour. On the agent template page, there is now a text area called
Windows Command(the formerCommandtext area has been renamed toUnix Command. The motivation behind this is my team's need to allow the containers to connect via cygwin as opposed to powershell. I also made it so one can write${unixCommand}on theWindows Commandfield to interpolate the default bash behaviour without needing complicated parsing.Closes issue #53.