New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve verifications to verify rollout deployments #321

Open

ViliusS wants to merge 2 commits into jenkinsci:develop from ViliusS:improve-verify-deployments-1

ViliusS commented Apr 9, 2023

This PR uses the same algorithm as "kubectl rollout status" for the verification of rollout deployments.

Fixes #119

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Ensure that the pull request title represents the desired changelog entry
Please describe what you did
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue

Author

ViliusS commented Jun 26, 2023

ViliusS force-pushed the improve-verify-deployments-1 branch from 695feaa to 70109be Compare

June 28, 2023 11:08

ViliusS force-pushed the improve-verify-deployments-1 branch from 70109be to 9d124f6 Compare

July 27, 2023 12:55

ViliusS force-pushed the improve-verify-deployments-1 branch from 9d124f6 to 4a6e3b0 Compare

August 7, 2023 11:04


          Improve deployment verification

With the exception of progress deadline, it now uses the same algorith
as "kubectl rollout status":
https://github.com/kubernetes/kubectl/blob/f89fc21e9c51d313e923eb93d1ae83754be62019/pkg/polymorphichelpers/rollout_status.go#L80-L88

While at it, rename minimum replicas to desired replicas as per
Kubernetes terminology. Minimum replicas are more used in
Horizontal Pod Autoscaling, not the Deployment configuration.

ViliusS force-pushed the improve-verify-deployments-1 branch from 4a6e3b0 to 9167347 Compare

May 13, 2024 08:15


          Merge branch 'develop' into improve-verify-deployments-1

c4dfe64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet