Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder-level credentials are not displayed #97

Open
ghost opened this issue Sep 3, 2019 · 3 comments
Open

Folder-level credentials are not displayed #97

ghost opened this issue Sep 3, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Sep 3, 2019

Similar to a comment in #79 (comment) which is now closed.

Only credentials created at the System Level is rendered under the credentials list.

Can we add support for credentials associated at the folder level? Basically, I would like to eliminate the chance a pipeline may end up deploying a workload to the wrong cluster/project.

View source

@craigdbarber craigdbarber added the enhancement New feature or request label Sep 3, 2019
@craigdbarber
Copy link
Contributor

Hi @coolersport thanks for the feedback. This seems totally reasonable, we'll incorporate it into our road map.

@Wadeck
Copy link
Contributor

Wadeck commented Sep 10, 2019

It's perhaps due to the binding of the credentials search to Jenkins.get() in google-oauth-plugin, it should use the current item (like folder, etc)

@craigdbarber
Copy link
Contributor

@Wadeck seems reasonable. Would you feel comfortable submitting a PR with a fix? I'd be happy to review it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants