Show axis in table format even if there's only one value in the axis #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I understand the issue, but there is a use-case for the original behavior. In old cores there was no opportunity to specify labels for Matrix runs, so many people used a single axis (e.g. TARGET_LABELS) to specify the label requirements. This axis had only one value, hence it didn't influence the user layouts. This change is going to change the behavior. Maybe it's a right approach, but it requires a discussion |
…-project-plugin [maven-release-plugin] copy for tag matrix-project-1.7.1
brianzaky
approved these changes
May 12, 2018
mamh2021
pushed a commit
to mamh-java/matrix-project-plugin
that referenced
this pull request
Jul 6, 2020
User-defined Axis的配置，总是显示为表格的形式，就算只有一组值也显示为一个表格。 from jenkinsci#29
mamh2021
pushed a commit
to mamh-java/matrix-project-plugin
that referenced
this pull request
Jul 18, 2020
User-defined Axis的配置，总是显示为表格的形式，就算只有一组值也显示为一个表格。 from jenkinsci#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the current view of showing the axis when there's only 1 value is a bit messy and I very much prefer to show them inside a table cell regardless of the number of values in the axis.