[JENKINS-68562] Fix Repo checkouts on the built-in node for Windows controllers #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
commented
May 17, 2022
| @@ -31,4 +34,15 @@ public void configRoundTrip() throws Exception { | |||
| assertTrue(scm.isCleanFirst()); | |||
| assertEquals(manifestRepositoryUrl, scm.getManifestRepositoryUrl()); | |||
| } | |||
|
|
|||
| @Issue("JENKINS-68562") | |||
There was a problem hiding this comment.
The rest of this test class uses spaces, so I did too, even though RepoScm uses tabs. IDK if there is a particular preference.
Pldi23
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-68562, which was filed against Git, but the same issue should apply here.
On Windows,
Paths.getthrowsInvalidPathExceptionfor URL-like values such ashttps://whatever. This breaks the fixes for SECURITY-2478 in 3c8e623 for Jenkins controllers running on Windows that perform checkouts on the built-in node.CC @Pldi23 @rsandell