Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-42475 Add support for pipeline #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

froque
Copy link
Member

@froque froque commented Nov 20, 2024

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jglick
Copy link
Member

jglick commented Nov 20, 2024

This would not necessarily be a good idea. jenkins-infra/jenkins.io#7693 What does this plugin actually do that you could not do just as easily without any special plugin?

* Perform the sbt build. Interpret the command arguments and create a
* command line, then run it.
does not look particularly helpful.
public static final class SbtInstallation extends ToolInstallation implements
perhaps, but you can also use this with the tool step if you really want (though these days I would advise using container-based builds and ignoring the tool system).

@froque
Copy link
Member Author

froque commented Dec 4, 2024

The idea here is to simplify this

    tools {
      jdk 'java-1.8.0'
    }

    environment {
      SBT_HOME = tool name: '1.10.5', type: 'org.jvnet.hudson.plugins.SbtPluginBuilder$SbtInstallation'
      PATH = "${env.SBT_HOME}/bin:${env.PATH}"
    }

into this:

    tools {
      jdk 'java-1.8.0'
      sbt '1.10.5'
    }

@jglick do you object this change as is ? What do you propose instead ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants