Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI via Github Actions #45

Open
karel-brinda opened this issue Nov 24, 2024 · 1 comment
Open

CI via Github Actions #45

karel-brinda opened this issue Nov 24, 2024 · 1 comment

Comments

@karel-brinda
Copy link
Contributor

Hi @jermp, I was just wondering that it might be a good idea to include CI via Github Actions.

Fulgor is at this point a great SW, but one limitation that we as its users are constantly facing is the difficulty to reliably deploy it in essentially any real project. While some issues were of a one-time nature and could be easily fixed, e.g., the ones related to probabilistically failing index construction, others seem to be recursively reappearing (e.g., issues with compilation on different system), partially due to Fulgor's reliance on a pretty complex-to-compile stack including SSHash and GGcat and all the Rust-vs-C++ complexity.

It would extremely helpful if there could be at least basic unit / compilation / integration tests that would be executed across all officially supported platforms that could ensure that the program is compilable and works correctly correct. In addition, it would be extremely helpful if precompiled binaries could be provided (eg via Bioconda), as it's almost impossible to compile this in a reliable way on many clusters (think of an old CentOS without root even without zlib).

@jermp
Copy link
Owner

jermp commented Nov 26, 2024

Hi Karel, sorry for being slow to answer.
Continuous integration is a great idea; a workflow would be definitely nice to have.

On the other hand, I have no experience with distributing precompiled binaries via Bioconda.
It is surely possibile if someone is willing to try that :)

One thing to mention is that Fulgor is still in active development, i.e., in the near future is going
to improve even further. This means that we should also periodically update those binaries, etc.,
and I don't know how difficult that is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants