Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts are tiny when 2x2 #23

Closed
IanSavchenko opened this issue Dec 9, 2018 · 6 comments
Closed

Charts are tiny when 2x2 #23

IanSavchenko opened this issue Dec 9, 2018 · 6 comments

Comments

@IanSavchenko
Copy link
Contributor

Just received an update with 2 charts in a row and now they are tiny on my laptop screen :( It was pretty hard to use mouse-over even before, but now it's even harder...
Can I suggest reverting the change or adding some kind of minimal width with wrapping?

@jeroenheijmans
Copy link
Owner

@IanSavchenko Yeah, I also noticed on some of my leaderboards that my changes didn't go over so well. Especially when there's many members on the leaderboard.

I'll see if I can revert or update this change slightly. To make sure I'd cover your case as well, could you share the number of members on your board, or perhaps even a (blurred if you want to anonimize it) screenshot?

@IanSavchenko
Copy link
Contributor Author

I have 13 inch MacBook Pro + latest Chrome.

So this is how it looks with almost 50 people when I'm full screen and with 80% scaling (I usually split screen in two when solving tasks, so in this way can see all the text in AoC website).
screen shot 2018-12-09 at 18 58 44

Same state in dev tools
screen shot 2018-12-09 at 19 05 52

Just noticed that when I reset scaling to 100% and reload the page, it goes back to normal state, as it was before all the updates. So there is already scaling logic, it's just not dynamic! I think it's probably fine, but maybe slightly bigger min_width would be good.

@mebeim
Copy link
Contributor

mebeim commented Dec 9, 2018

Agreed, got a 22 inch 16:9 monitor (latest extension version and latest Chrome) on my home PC, and charts look pretty bad :\ They were way better when displayed one under another.

Here's a screenshot from my PC: screenshot

@jeroenheijmans
Copy link
Owner

@IanSavchenko @mebeim Oh my you have a lot of friends! 😅

I'll push a fix in a second, and will release a patch to the extension stores in the coming hours, so all should be well again come Day 10 of advent!

PS. I have less friends and a QHD screen, so I made a button to opt in on the 2x2 visualization (defaults to off, persists in localStorage):

image

@jeroenheijmans
Copy link
Owner

Ah yes by the way, the "responsiveness" isn't dynamic yet because I need to fix #17 first (right now the "responsiveness" is done once when loading the page - not so nice, I know 😄)

@mebeim
Copy link
Contributor

mebeim commented Dec 9, 2018

Cool button addition, good job 👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants