Skip to content

Latest commit

 

History

History
67 lines (41 loc) · 5.58 KB

CONTRIBUTING.md

File metadata and controls

67 lines (41 loc) · 5.58 KB
Raw

Contributing to Hyperspace

Welcome!

If you are here, it means you are interested in helping us out. A hearty welcome and thank you! There are many ways you can contribute to the Hyperspace project:

  • Offer PR's to fix bugs or implement new features
  • Review currently open PRs
  • Give us feedback and bug reports regarding the software or the documentation
  • Improve our design docs, examples, tutorials, and documentation

Please start by browsing the issues and leave a comment to engage us if any of them interests you. And don't forget to take a look at the project roadmap.

Here are a few things to consider:

  • Before starting working on a major feature or bug fix, please open a GitHub issue describing the work you are proposing. We will make sure no one else is already working on it and the work aligns with the project roadmap.
  • A "major" feature or bug fix is defined as any change that is > 100 lines of code (not including tests) or changes user-facing behavior (e.g., breaking API changes). Please read Proposing Major Changes to Hyperspace before you begin any major work.
  • Once you are ready, you can create a PR and the committers will help reviewing your PR.

Coding Style: Please review our coding guidelines.

Proposing Major Changes to Hyperspace

The development process in Hyperspace is design-driven. If you intend of making any significant changes, please consider discussing with the Hyperspace community first (and sometimes formally documented), before you open a PR.

The rest of this document describes the process for proposing, documenting and implementing changes to the Hyperspace project.

To learn about the motivation behind Hyperspace, see the talk Hyperspace: An Indexing Subsystem for Apache Spark from Spark+AI Summit 2020.

The Proposal Process

The process outlined below is for reviewing a proposal and reaching a decision about whether to accept/decline a proposal.

  1. The proposal author creates a design proposal issue describing the proposal.

  2. A discussion on the issue will aim to triage the proposal into one of three outcomes:

    • Accept proposal
    • Decline proposal
    • Ask for more details

    If the proposal is accepted/declined, the process is done. Otherwise, the discussion is expected to identify concerns that should be addressed by updating the proposal.

  3. Once comments and revisions on the design proposal issue are complete, there is a final discussion on the issue to reach one of two outcomes:

    • Accept proposal
    • Decline proposal

After the proposal is accepted or declined, implementation work proceeds in the same way as any other contribution.

Proposal Review

A group of Hyperspace team members will review your proposal and CC the relevant developers, raising important questions, pinging lapsed discussions, and generally trying to guide the discussion toward agreement about the outcome. The discussion itself is expected to happen on the issue, so that anyone can take part.

Consensus and Disagreement

The goal of the proposal process is to reach general consensus about the outcome in a timely manner.

If general consensus cannot be reached, the proposal review group decides the next step by reviewing and discussing the issue and reaching a consensus among themselves.

Submitting PRs

Once the proposal is accepted, the contributor is welcomed to start submitting PRs. Since a major feature typically requires big code changes, it would be preferred if the work is divided into smaller sub-tasks, where each task maps to one PR. Please refer to this doc why small PRs (if applicable) are preferred.

Becoming a Hyperspace Committer

The Hyperspace team will add new committers from the active contributors, based on their contributions to Hyperspace. The qualifications for new committers are derived from Apache Spark Contributor Guide:

  • Sustained contributions to Hyperspace: Committers should have a history of major contributions to Hyperspace. An ideal committer will have contributed broadly throughout the project, and have contributed at least one major component where they have taken an “ownership” role. An ownership role means that existing contributors feel that they should run patches for this component by this person.
  • Quality of contributions: Committers more than any other community member should submit simple, well-tested, and well-designed patches. In addition, they should show sufficient expertise to be able to review patches, including making sure they fit within Hyperspace’s engineering practices (testability, documentation, API stability, code style, etc). The committership is collectively responsible for the software quality and maintainability of Hyperspace.
  • Community involvement: Committers should have a constructive and friendly attitude in all community interactions. They should also be active on the dev and user list and help mentor newer contributors and users. In design discussions, committers should maintain a professional and diplomatic approach, even in the face of disagreement.