Assignment 1 review.

[jerryc-nguyen]

Hi @coderschoolreview , @avo1 I submitted assignment 1 and need your review. Many thanks.

[coderschoolreview]

Thanks for submitting on time (and still early!). We will review all the submissions this week and get back to you.

[minhchau273]

👍 Excellent work. You are getting so much done! 🚀 The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Excellent
• Code Style: Excellent
• Visual Design: Good
• Usability: Excellent

Overall: Excellent

Detailed Notes

• Great clean code. Good job utilizing the best parts from the style guide:
  • Ray Wenderlich Swift Style Guide
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response. For a more robust solution, you can also investigate using an ORM like Pistachio.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Your error message should be displayed if a network request fails and hidden again if it succeeds. You have to create your own error message instead of using the alert controller. We mentioned it in the requirements. (You may not use UIAlertController or a 3rd party library to display the error.). Another issue is that after I dismiss the alert, your app show the black screen and no way to load the movies again on this screen.
  
• Consider a solution that allows a user to see the entire movie synopsis in the Movie Detail View. Right now it is being truncated. Allowing scrolling by adding a UIScrollView or using UITextView would fix that.
  
• Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read Design tips for iOS9.
• It's not a big deal but in case there is no result, you should show a label No results found to make your app more friendly 😉
• Good job with the collection view, the animation for the posters and loading the low-res image first, switch to high-res when complete.
• Great idea with using 2 navigation controllers with 1 view controller for the tab bar. 🍡
• It'd be better if you set orange color for this white space.
  

Great job dedicating enough time to do the homework. You learned a lot! Keep up the good work. 🏇

[jerryc-nguyen]

Many thanks for your review, I see a lots of great suggestion to improve. Let me update the app.