Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Changes To Be Made #102

Open
5 tasks
jescalan opened this issue Jun 9, 2015 · 2 comments
Open
5 tasks

Breaking Changes To Be Made #102

jescalan opened this issue Jun 9, 2015 · 2 comments
Labels

Comments

@jescalan
Copy link
Owner

jescalan commented Jun 9, 2015

So I'm thinking about some significant breaking changes that I'd like to have made before we hit 1.0, just going to list a few out here. If anyone else has contributions or ideas they are more than welcome!

  • Change scss adapter name to sass, since this is the name of the language as a whole, and since it now supports the sass syntax as of the most recent version.
  • Remove minify-html, minify-css, and minify-js adapters and make adapters for each individual compiler (html-minifier, clean-css, and uglify-js, respectively). Potentially keep the minify-*s, but only as aliases to a preferred minifier. This will allow for the additon of more minfiers, as there are a few
  • Also remove the markdown adapter and change this to marked instead. There are a number of other markdown compilers, and we should not be forcing anyone's hand.
  • Full code audit, removing any extra functions or properties that have been introduced by PRs that are either linked to external libraries which are no longer maintained, or cannot be explained fully by the contributor (example: accord.load customPath, what does it do? #89)
  • Convert to ES6
@Ed-0x1b
Copy link

Ed-0x1b commented Aug 7, 2017

Jade.js is changing to Pug.js on 2.0.0 - https://github.com/pugjs/pug

@jescalan
Copy link
Owner Author

jescalan commented Aug 8, 2017

@Ed-0x1b We already have a pug adapter, and have for a while 😁

https://github.com/jescalan/accord/tree/master/lib/adapters/pug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants