Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Stage Sourcemap Support #103

Open
jescalan opened this issue Jun 9, 2015 · 5 comments
Open

Multi Stage Sourcemap Support #103

jescalan opened this issue Jun 9, 2015 · 5 comments
Labels

Comments

@jescalan
Copy link
Owner

jescalan commented Jun 9, 2015

In addition to simply accepting input text, each adapter should also accept an object containing input text and a sourcemap, and if the adapter produces a sourcemap of its own, merge it with the incoming sourcemap. Not a super complicated change, nor is it breaking, just want to have it noted here as this will be an important feature down the line.

@dbox
Copy link

dbox commented Jul 7, 2015

So is this why sourcemaps wouldn't work if I'm using both postcss and stylus as multi compile?

@jescalan
Copy link
Owner Author

jescalan commented Jul 8, 2015

Yes. Won't be a huge feature to add though, just need some time or someone
to contribute!

On Tue, Jul 7, 2015, 8:51 PM Daniel Box [email protected] wrote:

So is this why sourcemaps wouldn't work if I'm using both postcss and
stylus as multi compile?


Reply to this email directly or view it on GitHub
#103 (comment).

@dbox
Copy link

dbox commented Jul 10, 2015

maybe @hhsnopek ? 👼 🙏

@hhsnopek
Copy link
Contributor

Could you define merge @Jenius? For instance if we have multipass on .css.styl, which will start with stylus, then move to postcss, will it only contain the original stylus code then append the postcss code?

@jescalan
Copy link
Owner Author

Basically input should take either a string or an object, then if its an object and has a sourcemap key/val pair, it should run a sourcemap merge as such: https://github.com/jenius/autoprefixer-stylus/blob/master/index.js#L45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants