-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add debug mode #37
Comments
Hmm, could you add more details here on how you would expect the output to look and/or proposed implementation? |
I can do one better: I'll show you! :D this is a few lines of the [
{
"filename": "/usrdata/web/accord/test/fixtures/haml/precompile.haml",
"engineName": "hamljs",
"method": "compileFile",
"duration": 0.000350218,
"deps": [ ],
"isolated": false,
"time": 1405039216675
},
{
"engineName": "marc",
"method": "render",
"duration": 0.001030628,
"deps": [ ],
"isolated": false,
"time": 1405039216696
},
{
"filename": "/usrdata/web/accord/test/fixtures/marc/basic.md",
"engineName": "marc",
"method": "render",
"duration": 0.000211233,
"deps": [ ],
"isolated": false,
"time": 1405039216698
},
{
"filename": "/usrdata/web/accord/test/fixtures/marc/basic.md",
"engineName": "marc",
"method": "renderFile",
"duration": 0.000532603,
"deps": [ ],
"isolated": false,
"time": 1405039216698
}
] And this is the proposed implementation: https://github.com/slang800/accord/blob/master/lib/index.coffee#L46 It's an event emitter because having a ongoing log would basically be an intentional memory leak, and changing the return value of the promise would be really lame to just include optional info (promises can't return multiple values). |
Ok, so we discussed this today as well and I think the implementation we were thinking about was that we would have a |
The deps would be in the job log (under the |
Hey @slang800, just a reminder to make sure to chat with one of us about projects before starting work on them so we can be sure we are all on the same page. But of course appreciate all the thought and hard work going into this! |
Haha, I did chat with you about it - take a look through the readme (which I published just now) & you should remember |
I don't remember this specific one, but looking through the readme it looks ok. How does this fit into the greater scheme of things? |
It was a part of the conversation on July 18th before we went to "The Bridges" restaurant to celebrate Henry's internship, and was the solution for 1:many compile relations & the complexity that they would add. Rather than adding this type of relationship to the roots core, accord-watcher would abstract file watching and file-dependency-management into a separate library, allowing the roots core to focus on more user-facing things (like setting where each file goes when compiled, and what the steps in compilation are). Though I just recently came up with the name... I only called it "a separate library" when we were talking. As for the greater scheme of things: it's another thing to abstract out of the roots core as we break down roots into separate modules. |
to optionally collect stats on compilation time for each file
The text was updated successfully, but these errors were encountered: