-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number of required horcruxes differs between CLI and .horcrux files #15
Comments
@AlphaJack the At the top of each file it shows how many other horcruxes in total there are, while the command tells you how many it needs (the threshold) to reconstruct the original file. Note: the comment at the very top is just a user friendly message, if you look at the header you can find the important information. I made a test file, with your parameters, and if you look at the header, you can see
Well, yeah, when t > n it will obviously break, you want to reconstruct the file from more horcruxes than there are! Let's get your second example, with
That obviously doesn't work! It even gives you the error I don't understand what you mean by
If you have an unrelated request, just make another issue for it. |
My suggestion about the header content is replace
with
Because with
This interval range is wrong because you can only enter a number equal or above 5 (not 2), so it should be (5-99) instead of (2-99) I wrote "[5,inf]" because you can pick up a valid number higher than 99.
Nevermind. |
I'm sorry, I misunderstood your ideas the first time. I agree with both of your suggestions. |
No problem, I expressed myself badly in my original post, I'm glad it helped |
If I run
horcrux -t 3 -n 5 split diary.txt
I get five .horcruxes, and each one containsIt says I must need this horcrux plus other four to resurrect the original file, while If I delete three horcruxes,
./horcrux bind .
returnssaying that I need at least (only) three horcruxes
Is this a feature? ; )
EDIT: I also noticed a t>n error:
.horcrux -n 5 split diary.txt
and enter t=99 I get the following message. Should the interval be "[2-5]" instead of "(2-99)"?.horcrux -t 5 split diary.txt
and enter n=3 I get an error. Should the interval be "[5-inf]" instead of "(2-99)"?Unrelated request, is it possible to add
armv7h
to the list of pre-released binaries?The text was updated successfully, but these errors were encountered: