Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable commit tree highlight color #3627

Open
anikiforov opened this issue Jun 1, 2024 · 0 comments · May be fixed by #4032
Open

Configurable commit tree highlight color #3627

anikiforov opened this issue Jun 1, 2024 · 0 comments · May be fixed by #4032
Labels
enhancement New feature or request

Comments

@anikiforov
Copy link
Contributor

anikiforov commented Jun 1, 2024

Is your feature request related to a problem? Please describe.
When using a light terminal background, the commit tree highlight in the commit view is hardly visible (and might not be visible on certain backgrounds). E.g.:

Describe the solution you'd like
The straightforward solution would be to make the highlight color configurable instead of hardcoding it here in the graph.go

Describe alternatives you've considered
Perhaps there is a way to programmatically determine whether the light or dark background / theme is used, and auto-select the highlight color accordingly.

Alternatively, it may be possible to use one of the theme colors defined by a user in their terminal settings as the highlight color.

Additional context
I am open to implementing this. Any suggestions and comments regarding the best approach for implementation are welcome.

@anikiforov anikiforov added the enhancement New feature or request label Jun 1, 2024
@BElluu BElluu linked a pull request Nov 3, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant