Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# .NET implementation to the list #26

Closed
firenero opened this issue Jul 13, 2023 · 5 comments
Closed

Add C# .NET implementation to the list #26

firenero opened this issue Jul 13, 2023 · 5 comments

Comments

@firenero
Copy link
Contributor

Hi,

I've created a performance-oriented implementation of TypeId in C#: https://github.com/firenero/TypeId
What should be done to add it to the list and mark it as verified? I've seen the discussion about automated flow for validation (#23 ) but not sure if there is something in place already.

Also thanks for the reference implementation and examples of valid/invalid typeIds. They were really helpful during developing my library.

@loreto
Copy link
Contributor

loreto commented Jul 14, 2023

@firenero Thanks for contributing!

Send me:

  1. A link to your tests and the github action showing them passing.
  2. A PR adding your implementation to the README

I'll review and approve.

For the README PR, please send it in our opensource monorepo (https://github.com/jetpack-io/opensource/blob/main/typeid/typeid/README.md) and once it's checked in, it'll get published in the typeid repo automatically

@firenero
Copy link
Contributor Author

@loreto
Copy link
Contributor

loreto commented Jul 14, 2023

Merged!

@loreto loreto closed this as completed Jul 14, 2023
@firenero
Copy link
Contributor Author

Thanks @loreto. Will you add the verification label yourself when you're done with the review or do I have to create a new PR for that?

@loreto
Copy link
Contributor

loreto commented Jul 14, 2023

Ah sorry, I missed that you hadn't added the verification date already. Go ahead and send me a PR and I'll approve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants