-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C# .NET implementation to the list #26
Comments
@firenero Thanks for contributing! Send me:
I'll review and approve. For the README PR, please send it in our opensource monorepo (https://github.com/jetpack-io/opensource/blob/main/typeid/typeid/README.md) and once it's checked in, it'll get published in the |
Hi @loreto Tests are located in this folder: https://github.com/firenero/TypeId/tree/main/src/FastIDs.TypeId/TypeId.Tests/TypeIdTests |
Merged! |
Thanks @loreto. Will you add the verification label yourself when you're done with the review or do I have to create a new PR for that? |
Ah sorry, I missed that you hadn't added the verification date already. Go ahead and send me a PR and I'll approve! |
Hi,
I've created a performance-oriented implementation of TypeId in C#: https://github.com/firenero/TypeId
What should be done to add it to the list and mark it as verified? I've seen the discussion about automated flow for validation (#23 ) but not sure if there is something in place already.
Also thanks for the reference implementation and examples of valid/invalid typeIds. They were really helpful during developing my library.
The text was updated successfully, but these errors were encountered: