refactor: Word line renderer uses PREG_SPLIT_NO_EMPTY

The previous "wordGlues" bug fix should've also fixed this.

Signed-off-by: Jack Cherng <[email protected]>

Author: jfcherng

src/Renderer/Html/LineRenderer/Word.php

@@ -22,12 +22,7 @@ public function render(MbString $mbOld, MbString $mbNew): LineRendererInterface
         static $splitRegex = '/([' . RendererConstant::PUNCTUATIONS_RANGE . '])/uS';
         static $dummyHtmlClosure = RendererConstant::HTML_CLOSURES[0] . RendererConstant::HTML_CLOSURES[1];
 
-        // using PREG_SPLIT_NO_EMPTY will make "wordGlues" work wrongly under some rare cases
-        // failure case:
-        //     old: "good-looking-x"
-        //     new: "good--y"
-        // notice that after glueing, the 2nd "-" in the new should be in the diff segment
-        $pregFlag = \PREG_SPLIT_DELIM_CAPTURE;
+        $pregFlag = \PREG_SPLIT_DELIM_CAPTURE | \PREG_SPLIT_NO_EMPTY;
         $oldWords = $mbOld->toArraySplit($splitRegex, -1, $pregFlag);
         $newWords = $mbNew->toArraySplit($splitRegex, -1, $pregFlag);