Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager-.hostname is always the host running the code, not the server we are connected to #48

Open
TrevorPH opened this issue Oct 13, 2019 · 1 comment

Comments

@TrevorPH
Copy link

When using manager = asterisk.manager.Manager() then manager.hostname is always set to the hostname of the machine running the python code. Am I alone in expecting that this should really be the hostname of the client we're talking to instead?

@TrevorPH
Copy link
Author

Well, this makes it work how I think it probably should work. I cannot see any point in having it tell me what the hostname of the machine running the pyst2 code is. If I do want to know that then there are already ways to do that. What I want it to tell me is the remote hostname of the connected asterisk manager that this asterisk.manager.Manager() is connected to and the patch attached makes it do that though I am unsure about setting it to "Unconnected" in _init though it is accurate (otherwise it also shows up as the pyst2 code machine when the manager isn't connected)

pyst2-manager-hostname.patch.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant