From f7b941c71ea6ff44a23b781452510683e01ff242 Mon Sep 17 00:00:00 2001 From: Eli <88557639+lishaduck@users.noreply.github.com> Date: Sat, 31 Aug 2024 22:33:41 -0500 Subject: [PATCH] chore: fix ls-engines Ok, so this one is complicated. SemVer wise, we should be able to support glob 10 & glob 11. The only breaking change is the engine. Therefore, the "correct" specifier is indeed `^10.2.6 || ^11.0.0`. We support both, if you need an older engine, you should use an older version. In fact, npm is supposed to do this automatically. However, up until `npm-pick-manifest@9.1.0` (included in `npm@10.8.2`), there was a longstanding bug where it didn't! The code was there, but the logic didn't work right and after Isaacs moved on to vlt, his PR fixing this got stalled. After the `glob` fiasco, he rebased the PR and it's now fixed, but the change wasn't backported. Because we support Node 14, we support `npm@6.14.18`, so we can't take advantage of this. Instead, we just have to tolerate a slightly old version of glob. Oh well. I also removed "enginesStrict" again because our engine declaration is now higher than technically needed because `glob` only declares support for the latest versions of Node branches. --- package-lock.json | 2 +- package.json | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index a03dafad1..6a67118be 100644 --- a/package-lock.json +++ b/package-lock.json @@ -17,7 +17,7 @@ "find-up": "^4.1.0 || ^5.0.0", "folder-hash": "^3.3.0", "fs-extra": "^9.0.0", - "glob": "^10.2.6 || ^11.0.0", + "glob": "^10.2.6", "globby": "^13.2.2", "got": "^11.8.5", "graceful-fs": "^4.2.11", diff --git a/package.json b/package.json index 27e0d6e96..586314fff 100644 --- a/package.json +++ b/package.json @@ -68,7 +68,7 @@ "find-up": "^4.1.0 || ^5.0.0", "folder-hash": "^3.3.0", "fs-extra": "^9.0.0", - "glob": "^10.2.6 || ^11.0.0", + "glob": "^10.2.6", "globby": "^13.2.2", "got": "^11.8.5", "graceful-fs": "^4.2.11", @@ -116,6 +116,5 @@ "packageManager": "npm@8.19.4", "engines": { "node": "14 >=14.21 || 16 >=16.20 || 18 || 20 || >=22" - }, - "enginesStrict": true + } }