Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make isHeaderPngAccessible() toggleable for offline environments #226

Closed
ccano2011 opened this issue Nov 14, 2024 · 4 comments · Fixed by #235
Closed

Make isHeaderPngAccessible() toggleable for offline environments #226

ccano2011 opened this issue Nov 14, 2024 · 4 comments · Fixed by #235
Labels
feature request New feature or request

Comments

@ccano2011
Copy link

Is your feature request related to a problem? Please describe.

private static async isHeaderPngAccessible(): Promise<boolean> {

The new addition is nice, but waiting 2 minutes for it to timeout adds to build times in an offline environment

Describe the solution you'd like to see

  • uses: jfrog/setup-jfrog-cli@v4
    with:
    disable-online-header-summary: true

Describe alternatives you've considered

Include the header in the binary or remove that online check altogether

Additional context

No response

@ccano2011 ccano2011 added the feature request New feature or request label Nov 14, 2024
@hazeltonl
Copy link
Contributor

Maybe even just reduce the timeout?

@CrafterJSS
Copy link

Replicated the issue:
This is annoying with multiple jobs (potentially in series).
Image

@ccano2011
Copy link
Author

@EyalDelarea @eyalbe4 Could you take a look at this?

@EyalDelarea EyalDelarea linked a pull request Dec 15, 2024 that will close this issue
2 tasks
@EyalDelarea
Copy link
Contributor

Hey @ccano2011,

Thank you for submitting this feature request.
I would suggest reducing the timeout and avoiding multiple checks, rather than requiring the user to specify whether there is an internet connection.
I've opened a PR to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants