-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IFileService should provide a method to see if a file exists #24
Comments
@wo80 Want to contribute to the project? |
Haven't used this in a while. I was just cleaning up Github issues that seemed stale / not relevant anymore. Sure I could do a pull request. But both this project and Griffin.Framework look abandoned. Do you have any plans to revive them? |
I still use Griffin.Framework. working on a new and more modern networking layer in it (although slowly). also moving the data mapper to a separate repository. |
Yeah, I saw the new_networking_code branch. Hope you find some time to finish this, looks promising! I'll do the pull request, but since I don't have the framework targets for legacy net4 versions installed, I'd have to remove those from the project file. |
Having a
IFileService.FileExists(Uri uri, string fileName)
method would allow re-using theIFileService
in theDefaultDocumentRouter
(instead of passing a root dir and duplicating the path calculation).EDIT: The
DiskFileService
implementation could look something likeEDIT 2: Or have two methods
Alternatively, adding
GetFullPath
to the interface would solve the problem.The text was updated successfully, but these errors were encountered: