Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version calculation on branches breaking change from 1.7.1 to 1.8.0 #166

Open
fjakop opened this issue Nov 2, 2021 · 0 comments
Open

Version calculation on branches breaking change from 1.7.1 to 1.8.0 #166

fjakop opened this issue Nov 2, 2021 · 0 comments

Comments

@fjakop
Copy link

fjakop commented Nov 2, 2021

version: 1.8.0

usage context:

maven command line: 3.8.3

Problem description:

I create a non-default branch, e.g. dev/feature, do a commit on this branch and tag this commit with an annotated tag, e.g. 3.0.1.

jGitVer-maven-plugin v1.7.1 would calculate 3.0.1-dev_feature on mvn validate which is a qualified release version.
jGitVer-maven-plugin v1.8.0 would calculate 3.0.2-dev_feature-SNAPSHOT on mvn validate which is a snapshot version.

extensions.xml

<extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
            xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd">
    <extension>
        <!-- see https://github.com/jgitver/jgitver-maven-plugin -->
        <groupId>fr.brouillard.oss</groupId>
        <artifactId>jgitver-maven-plugin</artifactId>
        <version>1.8.0</version>
    </extension>
</extensions>

jgitver-config.xml

<configuration xmlns="http://jgitver.github.io/maven/configuration/1.1.0"
               xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
               xsi:schemaLocation="http://jgitver.github.io/maven/configuration/1.1.0 https://jgitver.github.io/maven/configuration/jgitver-configuration-v1_1_0.xsd">
    <exclusions>
        <exclusion>${maven.repo.local}</exclusion>
    </exclusions>
</configuration>

No further configuration in pom.xml

I would expect the same behaviour as in 1.7.1, as this change would be a breaking one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant