Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base ssl-proxies-tomcat on tomcat7 #28

Open
bbockelm opened this issue Oct 23, 2012 · 5 comments
Open

Base ssl-proxies-tomcat on tomcat7 #28

bbockelm opened this issue Oct 23, 2012 · 5 comments

Comments

@bbockelm
Copy link
Contributor

Right now, the ssl-proxies-tomcat code is based on tomcat6. Tomcat6 isn't in maven, meaning things don't compile in the default profile.

@jrevillard
Copy link

Hi,

Tomcat6 is in maven in fact:

    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>catalina</artifactId>
      <version>6.0.24</version>
      <scope>provided</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.tomcat</groupId>
      <artifactId>coyote</artifactId>
      <version>6.0.24</version>
      <scope>provided</scope>
    </dependency>

Best,
Jerome

@ellert
Copy link
Contributor

ellert commented Aug 21, 2013

For me, whether it is in the maven repo or not is not important. I never claimed it wasn't (that was Brian). I think it is a good thing to do for other reasons.

This is more about keeping the dependencies updated, similar to when bc 1.46 was replaced with bc 1.49 as the bouncycastle dependency.

You can still build for tomcat 5, 6 and 7 just as before. This patch only changes which is selected by default if no profile is requested.

Fedora no longer provides tomcat 6 since Fedora 19.

@bbockelm
Copy link
Contributor Author

I'm happy with making tomcat7 the default. @jrevillard - any objections?

@jrevillard
Copy link

Absolutely no objection as far as I can still produce tomcat6 version... which is the case.

Best.

@ellert
Copy link
Contributor

ellert commented Oct 20, 2014

Why is this still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants