Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.js #4

wants to merge 1 commit into from

Conversation

sansamour
Copy link
Contributor

Fix error: TypeError: Cannot set property 'length' of undefined

Fix error: TypeError: Cannot set property 'length' of undefined
@jhiesey
Copy link
Owner

jhiesey commented Jul 28, 2018

Thanks!

obj is already set here: https://github.com/sansamour/mp4-box-encoding/blob/9323f264ca3eea19ec065ac3b18a13edc2a6af0a/index.js#L151

Is .decode()returning undefined? If so that's the place to fix it.

@sansamour
Copy link
Contributor Author

sansamour commented Jul 29, 2018

I know you defined it here:

var obj = {}

But i ran code test i saw error:

TypeError: Cannot set property 'length' of undefined

so, i added line:

if(obj == undefined) obj = {}

Code test ran well

I think perhaps this line return undefined

obj = decode(buffer, start, end)

@nklhtv
Copy link

nklhtv commented Jan 27, 2021

this line returns undefined. its not implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants