Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rebase if PR is up to date #1

Open
bergmark opened this issue May 31, 2022 · 1 comment · May be fixed by #2
Open

Do not rebase if PR is up to date #1

bergmark opened this issue May 31, 2022 · 1 comment · May be fixed by #2

Comments

@bergmark
Copy link

bergmark commented May 31, 2022

Thanks for writing this action! I have been trying out the github merge queue beta but it is not yet usable (for us), and auto-merge together with this seems to provide a much better workflow.

One thing I noticed is that rebases will happen even if branches are already up to date, changing commit hashes and triggering extra CI runs unnecessarily. The impact is not so bad as our CI will either abort the older builds, or they will fail because the commit hashes are now missing.

Still, it would be nice if the rebases did not happen if the branch is already up to date.

@Piyushhbhutoria Piyushhbhutoria linked a pull request Jan 26, 2024 that will close this issue
@Piyushhbhutoria
Copy link

@bergmark Please check my fork for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants