Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

fix: align icons on filter select #370

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DannyLuo-zp
Copy link

PR checklist

Please tick all of the below (if a certain item is not required for this PR please tick the box anyway)

Docs

  • If you added new code; is it self documenting? (all the variable names clear, comments added where appropriate)
  • If you touched existing code; did you refactor existing naming, added comments where necessary?

Tests

  • If your ticket adds new functionality; have you added unit tests to verify behaviour?
  • If your ticket alters user interaction with the UI; have you added integration tests?
  • Do your tests check for every convievable user behabviour? (all behaviours the user can perform)

Typing

  • If you added new code; have you added typing?
  • If you touched existing code; have you improved its typing?

Styling

  • If new styles were created; Did you refactor/add more styles in css-in-js style?
  • Are all fonts, sizes, colours, margins, paddings in line with designs?
  • Did you perform a visual comparison of the implementation with the designs?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants