Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embark actions for pods #98

Closed
jinnovation opened this issue Jan 20, 2023 · 4 comments
Closed

Embark actions for pods #98

jinnovation opened this issue Jan 20, 2023 · 4 comments

Comments

@jinnovation
Copy link
Owner

Can start with a map that only binds kele-get. This would be a little contrived, since kele-get is the only resource-related command at the moment, but it'd give us a springboard to start implementing and binding other pod-related functionality, e.g. fetching and following logs.

@ashlineldridge
Copy link

ashlineldridge commented May 18, 2023

This is a great idea. I really like the direction this project is going! An Embark action for port-forwarding would be another good use-case. At the moment, Embark seems to consider Kele completion candidates as a generic identifier and so you get the default action keymap. If I understand how this works, if you could categorize the resource candidates with their own symbol then people could start writing their own Embark actions by adding to embark-keymap-alist?

@jinnovation
Copy link
Owner Author

If I understand how this works, if you could categorize the resource candidates with their own symbol then people could start writing their own Embark actions by adding to embark-keymap-alist?

Absolutely. I haven't had the chance to explore this in-depth, but my thinking is very aligned w/ your idea here. Basically:

  1. Associate resource candidates with symbols corresponding to their kind, e.g. kele-pod or kele-customresourcedefinition;
  2. Provide a handful of starter Embark actions for select kinds;
  3. Provide convenient hook mechanisms for users to write their own kind-specific Embark actions (as you describe)

@jinnovation
Copy link
Owner Author

Deprioritizing Embark integrations in favor of fleshing out Transient-based usage first. Transient is in core Emacs while Embark is not, which means that improvements we make to Transient usage will have broader reach and appeal.

@jinnovation jinnovation closed this as not planned Won't fix, can't repro, duplicate, stale Apr 16, 2024
@jinnovation
Copy link
Owner Author

In this particular case, I suspect we'll be able to reap much of the same benefits of specialized Embark keymaps with resource-specific suffixes on kele-resource -- a pattern we introduced in #187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants