-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Say/clip commands don't seem to use new announcement API features #808
Comments
This project has 147 open issues and 17 pull requests, and the last release was 4 years ago.... a lot of people including myself would like to help in keeping this project maintained and up-to-date, but we are all subject to @jishi allowing that.... |
Thanks, @jsiegenthaler, I'm also interested. If @jishi has abandoned the project (I'm not blaming her/him, it is a great project) what is the best way forward in your opinion? |
I guess @jishi has to invite other people to collaborate |
+1 for me also hoping this could use the native commands/API. Performing a TTS while doing Atmos playback on an ARC soundbar doesn't recover well. I don't believe @jishi has abandoned it. There were comments in other issues that they are happy to review and accept quality code merges. I'm sure everyone would appreciate a few more contributors - just pick something to improve, fork, update, merge request. Hard to convince them it will be well-done until it's seen. |
In response to @jsiegenthaler Here are my 2 forks of node-sonos-http-api and node-sonos-discovery. https://github.com/barrydegraaff/node-sonos-discovery To make it work, install the original node-sonos-http-api and then copy paste the files from my repo's over the originals to add additional features and fixes. You will have to copy node-sonos-discovery into the node_modules of node-sonos-http-api. Many of the added work comes from pull requests and issues from the original project and some own work. Please let me know if it works for you. node-sonos-discoveryThis is a dependancy of the node-sonos-http-api, with the following changes:
node-sonos-http-apiThe following API's are added: addtoqueue
Examples:
removefromqueue loudness
balance
led
putting this info in https://github.com/barrydegraaff/node-sonos-http-api/wiki |
Why can't the many forks and branches be merged into one master project so that we have a single, stable, known good working project? It's really difficult for a normal user to follow all the various branches and forks and know which is the newest and best to use.... I don't want to have to review everyone's changes to make a decision as to which fork would be the best for me. |
In an ideal world... most of the changes above have been sent as PR's to this project some time ago, I stopped sending PR's as nothing happens, I collected all my changes in one repo, you can use them -or not- or use them as reference, it is what I did with everyone else's PR's. |
Hi. It seems as if the clip/clipall, and say/sayall commands are changing the playback stream for Sonos, instead of using the dedicated Sonos API commands for tts and playing clips, because Sonos now supports ducking current audio, and playing a clip or TTS announcement, then restoring original audio to it's current volume. When playing a clip through this server, it changes the playback to the mp3 file, and does not resume playback of previously playing material. If possible, using the Sonos-specific commands for announcements would eliminate the need to figure out what was playing beforehand, etc, because it doesn't touch the current audio stream at all, it just plays over it. Just a thought/observation, let me know if I can be of any help in testing etc.
Thanks so much!
The text was updated successfully, but these errors were encountered: