-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable VOSK Transcription #1343
Conversation
ENABLE_VOSK and VOSK_SERVER
when checking for empty GLCOUD credentials, also check if VOSK is disabled first
I added a new var ENABLE_GCLOUD_TRANSCRIPTION but I am not sure, if my code at jigasi/rootfs/etc/services.d/jigasi/run seting the GCLOUD ENV for the key.json is working as intended |
I also am not sure, if it would be better/nicer if we can chain the check for the GCLOUD creds in the 10-config: I wanted to AND together the following checks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the requested changes
Is there anything left to do? I would be happy to help. It would be very useful when this gets merged. Thanks |
I updated the requested changes (e.g. the variablenaming ENABLE_VOSK_TRANSCRIPTION) but I need to test it out on my testsystem first, which I unfortunately didnt get around to yet. If I botched up something, I also break the GCLOUD transcription ability, which more users seem to use than VOSK :) Also I am not sure about the logic, that checks if transcriptions are on (but not gcloud) which I will get around to next week hopefully |
Hi, is there any update on this, and is there anything I can do to help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to me one variable was missed when renaming
@janonym1 is there an update on this ? Would love to help if necessary. |
@debendraoli @charles-zablit @rouaidakacem and everyone else asking to help: could you test this PR and report if it works, and in case you have to make any changes, which ones? Because even with my proposed change, I can't get this to work. |
Co-authored-by: Kim Brose <[email protected]>
Been patiently waiting for this, hoping to see this in a release soon! Would love to help/test if there's an update on this |
There is currently a conflict that needs to be fixed. |
Hi @saghul What needs to be done here? I would like to help. It looks like the changes you requested have not been reviewed by you. Or have I missed something? How can I/we help to get this merged? |
This is not a jigasi issue, this is configuration issue and should be fixed, maybe in this PR? |
I think I fixed that already. If you set ENABLE_TRANSCRIPTIONS the sip config is skipped now. |
Hey fellows, can we please prioritize this somehow? getting into compliance issues for some users. |
Can you resolve the conflicts, please? |
@saghul is there anything missing here? |
Please take a look at commit M4GNV5@d44daf2 which should address the open issues from @saghul - I am interested in getting this merged as well, thus I asked @M4GNV5 for this contribution. |
Hey @damencho, these commits have no conflict with Also, I am willing to test this work today, if there's a container image/tag for this. I am trying to create my own image, since its a good amount of learning curve for me, it will take time. @zobadaniel if it is possible for you to provide an image out of M4GNV5@d44daf2 branch, it will accelerate things. Thanks |
|
Dear @janonym1 can you please update this PR with M4GNV5@d44daf2 so that the requested changes are visible here? |
@aslam-t I have pushed my latest set of jitsi containers to docker, please look here: https://hub.docker.com/repositories/zalozbadev and pick the tag "stable-9584-1_custom-4" for each of the jitsi containers. It includes this PR and #1737 and works for me. I cannot update this PR myself, so the requested changes aren't directly visible. #1737 will be updated with the necessary changes soon, we need to sort out some merge issues there first. |
Hello @zobadaniel , I have tested your docker image for jigasi and did not work! Thanks |
@zobadaniel , still getting Transcriptions: One or more google cloud environment variables are undefined |
Hi, sorry for the delays, I think I will have time in the coming weekend or week to take another look at this |
Hi y'all: sorry for the likely disruptive changes, but I wanted to update everybody on this thread about our plan to move some bits around in order to make the transcriber a separate parallel component. This includes a new transcriber.yaml docker-compose file, and also will split the sip-communicator.properties file into pieces based on the jigasi mode. All this to say I hope it makes the sort of proposed changes above easier to reason about, but will mean further updates on this PR. I intend to get some progress on that in the next days, so I will link my PR when it's in any shape to discuss. |
My new PR splits out the config into different files based on jigasi role, and adds a new docker-compose file: |
Hello @aaronkvanmeerten , Thanks for update. Thanks |
This sounds like a late arrival summaries to me. I believe that might be possible, depending on how it is stored. This would be a customization from the iframe API or via custom client code however, it's not something we support out of the box. |
I have question is it possible to transcibe multiple lanaguages at the same time using gclound or vsok ? |
I feel this thread is getting out of context. Please direct such questions to https://community.jitsi.org/ |
This Pr is like 2 year old so its normall thanks for guidense I will ask there |
Hi @aaronkvanmeerten , great job. I believe your changes are already in master branch, Do you have any estimated release date? Would you include this issue about being able to use, for example Vosk, instead of Google, without the need of configure google env vars? Do you have any documentation about the features/bug fixes in this version? I'm about to add transcription to my JITSI, but maybe it is worth to wait for your release. |
We should have a new stable release with the changes already in master this week. Here's one more PR that needs to be merged to fully support Vosk. Once merged/marked stable then you'd just set: JIGASI_TRANSCRIBER_CUSTOM_SERVICE=org.jitsi.jigasi.transcription.VoskTranscriptionService Until the time it's merged, you can provide a custom jigasi config in /config/custom-sip-communicator.properties with the appropriate snippet it will be appended to the bottom of the file: Edit: it's merged now, so once we tag the latest stable you should be able to do the environment variable pieces above. |
Vosk config has been added recently. |
the vars are working and so vosk but it still tries to contact google |
Can you show any logs? I haven't tested specifically for vosk only as I don't have an endpoint for taht one. I'm curious to see your jigasi configuration as well as any errors in startup? |
this is my .env config
|
It appears we need a new flag: Once this is merged and pushed into stable you can set that: Until the time it's merged, you can provide a custom jigasi config in /config/custom-sip-communicator.properties with the appropriate snippet it will be appended to the bottom of the file: |
this creates 2 (maybe) new ENV variables to allow for easier VOSK integration. Per default, it is assumed GCLOUD is always used and that makes it hard(er) to set up VOSK within docker-jitsi-meet
I still need to add the GCLOUD check and set for the ENV GOOGLE_APPLICATION_CREDENTIALS /config/key.json within the run script (jigasi/rootfs/etc/services.d/jigasi/run) but I am not sure how to best approach this. Maybe lets define an additional variable (ENABLE_GCLOUD_TRANSCRIPTION) and use that?